Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
918aa9e4
Unverified
Commit
918aa9e4
authored
May 30, 2023
by
Taha Tesser
Committed by
GitHub
May 30, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update Material 2 tests group comment (#127796)
fixes
https://github.com/flutter/flutter/issues/127795
parent
c5f45d71
Changes
20
Hide whitespace changes
Inline
Side-by-side
Showing
20 changed files
with
61 additions
and
39 deletions
+61
-39
about_test.dart
packages/flutter/test/material/about_test.dart
+3
-2
app_bar_test.dart
packages/flutter/test/material/app_bar_test.dart
+3
-2
banner_theme_test.dart
packages/flutter/test/material/banner_theme_test.dart
+3
-2
card_theme_test.dart
packages/flutter/test/material/card_theme_test.dart
+3
-2
circle_avatar_test.dart
packages/flutter/test/material/circle_avatar_test.dart
+3
-2
date_picker_test.dart
packages/flutter/test/material/date_picker_test.dart
+3
-2
date_range_picker_test.dart
packages/flutter/test/material/date_range_picker_test.dart
+3
-2
divider_theme_test.dart
packages/flutter/test/material/divider_theme_test.dart
+3
-2
drawer_test.dart
packages/flutter/test/material/drawer_test.dart
+3
-2
expansion_tile_test.dart
packages/flutter/test/material/expansion_tile_test.dart
+3
-2
floating_action_button_test.dart
...es/flutter/test/material/floating_action_button_test.dart
+3
-2
list_tile_test.dart
packages/flutter/test/material/list_tile_test.dart
+3
-2
navigation_bar_test.dart
packages/flutter/test/material/navigation_bar_test.dart
+3
-2
navigation_rail_test.dart
packages/flutter/test/material/navigation_rail_test.dart
+4
-1
popup_menu_theme_test.dart
packages/flutter/test/material/popup_menu_theme_test.dart
+3
-2
slider_test.dart
packages/flutter/test/material/slider_test.dart
+3
-2
slider_theme_test.dart
packages/flutter/test/material/slider_theme_test.dart
+3
-2
tab_bar_theme_test.dart
packages/flutter/test/material/tab_bar_theme_test.dart
+3
-2
tabs_test.dart
packages/flutter/test/material/tabs_test.dart
+3
-2
value_indicating_slider_test.dart
...s/flutter/test/material/value_indicating_slider_test.dart
+3
-2
No files found.
packages/flutter/test/material/about_test.dart
View file @
918aa9e4
...
...
@@ -1270,8 +1270,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgetsWithLeakTracking
(
'License page default title text color in the nested UI'
,
(
WidgetTester
tester
)
async
{
// This is a regression test for https://github.com/flutter/flutter/issues/108991
...
...
packages/flutter/test/material/app_bar_test.dart
View file @
918aa9e4
...
...
@@ -4935,8 +4935,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'SliverAppBar.medium defaults'
,
(
WidgetTester
tester
)
async
{
final
ThemeData
theme
=
ThemeData
(
useMaterial3:
false
);
...
...
packages/flutter/test/material/banner_theme_test.dart
View file @
918aa9e4
...
...
@@ -449,8 +449,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Passing no MaterialBannerThemeData returns defaults'
,
(
WidgetTester
tester
)
async
{
const
String
contentText
=
'Content'
;
...
...
packages/flutter/test/material/card_theme_test.dart
View file @
918aa9e4
...
...
@@ -161,8 +161,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Passing no CardTheme returns defaults - M2'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
MaterialApp
(
...
...
packages/flutter/test/material/circle_avatar_test.dart
View file @
918aa9e4
...
...
@@ -282,8 +282,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'CircleAvatar default colors with light theme'
,
(
WidgetTester
tester
)
async
{
final
ThemeData
theme
=
ThemeData
(
primaryColor:
Colors
.
grey
.
shade100
);
...
...
packages/flutter/test/material/date_picker_test.dart
View file @
918aa9e4
...
...
@@ -1857,8 +1857,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
group
(
'showDatePicker Dialog'
,
()
{
testWidgets
(
'Default dialog size'
,
(
WidgetTester
tester
)
async
{
...
...
packages/flutter/test/material/date_range_picker_test.dart
View file @
918aa9e4
...
...
@@ -1462,8 +1462,9 @@ void main() {
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Default layout (calendar mode)'
,
(
WidgetTester
tester
)
async
{
await
preparePicker
(
tester
,
(
Future
<
DateTimeRange
?>
range
)
async
{
...
...
packages/flutter/test/material/divider_theme_test.dart
View file @
918aa9e4
...
...
@@ -266,8 +266,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
group
(
'Horizontal Divider'
,
()
{
testWidgets
(
'Passing no DividerThemeData returns defaults'
,
(
WidgetTester
tester
)
async
{
...
...
packages/flutter/test/material/drawer_test.dart
View file @
918aa9e4
...
...
@@ -740,8 +740,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Drawer default shape'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
...
...
packages/flutter/test/material/expansion_tile_test.dart
View file @
918aa9e4
...
...
@@ -892,8 +892,9 @@ void main() {
},
variant:
const
TargetPlatformVariant
(<
TargetPlatform
>{
TargetPlatform
.
iOS
,
TargetPlatform
.
macOS
}));
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'ExpansionTile default iconColor, textColor'
,
(
WidgetTester
tester
)
async
{
final
ThemeData
theme
=
ThemeData
(
useMaterial3:
false
);
...
...
packages/flutter/test/material/floating_action_button_test.dart
View file @
918aa9e4
...
...
@@ -1073,8 +1073,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Floating Action Button elevation when highlighted - effect'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
...
...
packages/flutter/test/material/list_tile_test.dart
View file @
918aa9e4
...
...
@@ -2479,8 +2479,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'ListTile geometry (LTR)'
,
(
WidgetTester
tester
)
async
{
// See https://material.io/go/design-lists
...
...
packages/flutter/test/material/navigation_bar_test.dart
View file @
918aa9e4
...
...
@@ -915,8 +915,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Navigation destination updates indicator color and shape'
,
(
WidgetTester
tester
)
async
{
final
ThemeData
theme
=
ThemeData
(
useMaterial3:
false
);
...
...
packages/flutter/test/material/navigation_rail_test.dart
View file @
918aa9e4
...
...
@@ -3137,7 +3137,10 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Original Material 2 tests. Remove this group after `useMaterial3` has been deprecated.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Renders at the correct default width - [labelType]=none (default)'
,
(
WidgetTester
tester
)
async
{
await
_pumpNavigationRail
(
tester
,
...
...
packages/flutter/test/material/popup_menu_theme_test.dart
View file @
918aa9e4
...
...
@@ -400,8 +400,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Passing no PopupMenuThemeData returns defaults'
,
(
WidgetTester
tester
)
async
{
final
Key
popupButtonKey
=
UniqueKey
();
...
...
packages/flutter/test/material/slider_test.dart
View file @
918aa9e4
...
...
@@ -3632,8 +3632,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Slider can be hovered and has correct hover color'
,
(
WidgetTester
tester
)
async
{
tester
.
binding
.
focusManager
.
highlightStrategy
=
FocusHighlightStrategy
.
alwaysTraditional
;
...
...
packages/flutter/test/material/slider_theme_test.dart
View file @
918aa9e4
...
...
@@ -2075,8 +2075,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Slider defaults'
,
(
WidgetTester
tester
)
async
{
debugDisableShadows
=
false
;
...
...
packages/flutter/test/material/tab_bar_theme_test.dart
View file @
918aa9e4
...
...
@@ -614,8 +614,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Tab bar defaults (primary)'
,
(
WidgetTester
tester
)
async
{
// Test default label color and label styles.
...
...
packages/flutter/test/material/tabs_test.dart
View file @
918aa9e4
...
...
@@ -6015,8 +6015,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'TabBar default selected/unselected text style'
,
(
WidgetTester
tester
)
async
{
final
ThemeData
theme
=
ThemeData
(
useMaterial3:
false
);
...
...
packages/flutter/test/material/value_indicating_slider_test.dart
View file @
918aa9e4
...
...
@@ -189,8 +189,9 @@ void main() {
});
group
(
'Material 2'
,
()
{
// Tests that are only relevant for Material 2. Once ThemeData.useMaterial3
// is turned on by default, these tests can be removed.
// These tests are only relevant for Material 2. Once Material 2
// support is deprecated and the APIs are removed, these tests
// can be deleted.
testWidgets
(
'Slider value indicator'
,
(
WidgetTester
tester
)
async
{
await
_buildValueIndicatorStaticSlider
(
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment