Unverified Commit 906761cf authored by Peixin Li's avatar Peixin Li Committed by GitHub

Fix the message strings for xcodeMissing and xcodeIncomplete (#117922)

* Add macOS to xcodeMissing and xcodeIncomplete

* And unit test
parent 63653e82
...@@ -176,10 +176,10 @@ class UserMessages { ...@@ -176,10 +176,10 @@ class UserMessages {
'Launch Xcode and install additional required components when prompted or run:\n' 'Launch Xcode and install additional required components when prompted or run:\n'
' sudo xcodebuild -runFirstLaunch'; ' sudo xcodebuild -runFirstLaunch';
String get xcodeMissing => String get xcodeMissing =>
'Xcode not installed; this is necessary for iOS development.\n' 'Xcode not installed; this is necessary for iOS and macOS development.\n'
'Download at https://developer.apple.com/xcode/download/.'; 'Download at https://developer.apple.com/xcode/download/.';
String get xcodeIncomplete => String get xcodeIncomplete =>
'Xcode installation is incomplete; a full installation is necessary for iOS development.\n' 'Xcode installation is incomplete; a full installation is necessary for iOS and macOS development.\n'
'Download at: https://developer.apple.com/xcode/download/\n' 'Download at: https://developer.apple.com/xcode/download/\n'
'Or install Xcode via the App Store.\n' 'Or install Xcode via the App Store.\n'
'Once installed, run:\n' 'Once installed, run:\n'
......
...@@ -30,4 +30,10 @@ void main() { ...@@ -30,4 +30,10 @@ void main() {
checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform)); checkInstallationURL((Platform platform) => userMessages.androidSdkBuildToolsOutdated(0, '', platform));
checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform)); checkInstallationURL((Platform platform) => userMessages.androidStudioInstallation(platform));
}); });
testWithoutContext('Xcode installation instructions', () {
final UserMessages userMessages = UserMessages();
expect(userMessages.xcodeMissing, contains('iOS and macOS'));
expect(userMessages.xcodeIncomplete, contains('iOS and macOS'));
});
} }
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment