Unverified Commit 8e9b7872 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

[flutter_tools] switch linux desktop feature on (#60018)

Enable linux desktop feature on dev channel
parent e676024d
...@@ -114,6 +114,10 @@ const Feature flutterLinuxDesktopFeature = Feature( ...@@ -114,6 +114,10 @@ const Feature flutterLinuxDesktopFeature = Feature(
available: true, available: true,
enabledByDefault: false, enabledByDefault: false,
), ),
dev: FeatureChannelSetting(
available: true,
enabledByDefault: false,
),
); );
/// The [Feature] for Windows desktop. /// The [Feature] for Windows desktop.
......
...@@ -92,7 +92,7 @@ void main() { ...@@ -92,7 +92,7 @@ void main() {
test('flutter Linux desktop help string', () { test('flutter Linux desktop help string', () {
expect(flutterLinuxDesktopFeature.generateHelpMessage(), expect(flutterLinuxDesktopFeature.generateHelpMessage(),
'Enable or disable Flutter for desktop on Linux. ' 'Enable or disable Flutter for desktop on Linux. '
'This setting will take effect on the master channel.'); 'This setting will take effect on the master and dev channels.');
}); });
test('flutter Windows desktop help string', () { test('flutter Windows desktop help string', () {
...@@ -306,18 +306,18 @@ void main() { ...@@ -306,18 +306,18 @@ void main() {
expect(featureFlags.isLinuxEnabled, false); expect(featureFlags.isLinuxEnabled, false);
})); }));
test('flutter linux desktop not enabled with config on dev', () => testbed.run(() { test('flutter linux desktop enabled with config on dev', () => testbed.run(() {
when(mockFlutterVerion.channel).thenReturn('dev'); when(mockFlutterVerion.channel).thenReturn('dev');
when<bool>(mockFlutterConfig.getValue('enable-linux-desktop') as bool).thenReturn(true); when<bool>(mockFlutterConfig.getValue('enable-linux-desktop') as bool).thenReturn(true);
expect(featureFlags.isLinuxEnabled, false); expect(featureFlags.isLinuxEnabled, true);
})); }));
test('flutter linux desktop not enabled with environment variable on dev', () => testbed.run(() { test('flutter linux desktop enabled with environment variable on dev', () => testbed.run(() {
when(mockFlutterVerion.channel).thenReturn('dev'); when(mockFlutterVerion.channel).thenReturn('dev');
when(mockPlatform.environment).thenReturn(<String, String>{'FLUTTER_LINUX': 'true'}); when(mockPlatform.environment).thenReturn(<String, String>{'FLUTTER_LINUX': 'true'});
expect(featureFlags.isLinuxEnabled, false); expect(featureFlags.isLinuxEnabled, true);
})); }));
test('flutter linux desktop off by default on beta', () => testbed.run(() { test('flutter linux desktop off by default on beta', () => testbed.run(() {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment