Skip to content

F
Front-End
Unverified Commit 8de5a07c authored by Alexander Aprelev's avatar Alexander Aprelev Committed by GitHub
Browse files
Options

Revert "Disable usage of bare instructions in AOT (#27410)" (#27789) 

This reverts commit 965dc52e as performance gains seems to outweigh compressed apk size increase.
parent d8cd2ff4
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 9 deletions
packages/flutter_tools/lib/src/base/build.dart
View file @ 8de5a07c
...@@ -125,7 +125,6 @@ class AOTSnapshotter { ...@@ -125,7 +125,6 @@ class AOTSnapshotter {
final String depfilePath = fs.path.join(outputDir.path, 'snapshot.d'); final String depfilePath = fs.path.join(outputDir.path, 'snapshot.d');
final List<String> genSnapshotArgs = <String>[ final List<String> genSnapshotArgs = <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
]; ];
if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) { if (extraGenSnapshotOptions != null && extraGenSnapshotOptions.isNotEmpty) {
printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions'); printTrace('Extra gen_snapshot options: $extraGenSnapshotOptions');
......
packages/flutter_tools/test/base/build_test.dart
View file @ 8de5a07c
...@@ -193,7 +193,6 @@ void main() { ...@@ -193,7 +193,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--no-sim-use-hardfp', '--no-sim-use-hardfp',
...@@ -233,7 +232,6 @@ void main() { ...@@ -233,7 +232,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill', 'main.dill',
...@@ -273,7 +271,6 @@ void main() { ...@@ -273,7 +271,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
...@@ -318,7 +315,6 @@ void main() { ...@@ -318,7 +315,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
...@@ -359,7 +355,6 @@ void main() { ...@@ -359,7 +355,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'--no-sim-use-hardfp', '--no-sim-use-hardfp',
...@@ -399,7 +394,6 @@ void main() { ...@@ -399,7 +394,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-assembly', '--snapshot_kind=app-aot-assembly',
'--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}', '--assembly=${fs.path.join(outputPath, 'snapshot_assembly.S')}',
'main.dill', 'main.dill',
...@@ -457,7 +451,6 @@ void main() { ...@@ -457,7 +451,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
...@@ -502,7 +495,6 @@ void main() { ...@@ -502,7 +495,6 @@ void main() {
expect(genSnapshot.packagesPath, '.packages'); expect(genSnapshot.packagesPath, '.packages');
expect(genSnapshot.additionalArgs, <String>[ expect(genSnapshot.additionalArgs, <String>[
'--deterministic', '--deterministic',
'--no-use-bare-instructions',
'--snapshot_kind=app-aot-blobs', '--snapshot_kind=app-aot-blobs',
'--vm_snapshot_data=build/foo/vm_snapshot_data', '--vm_snapshot_data=build/foo/vm_snapshot_data',
'--isolate_snapshot_data=build/foo/isolate_snapshot_data', '--isolate_snapshot_data=build/foo/isolate_snapshot_data',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab