Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8ca99327
Unverified
Commit
8ca99327
authored
Mar 27, 2018
by
Hans Muller
Committed by
GitHub
Mar 27, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Corrected default tab indicator color (#15959)
parent
eb9fc2ba
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
12 additions
and
1 deletion
+12
-1
tabs.dart
packages/flutter/lib/src/material/tabs.dart
+1
-1
tabs_test.dart
packages/flutter/test/material/tabs_test.dart
+11
-0
No files found.
packages/flutter/lib/src/material/tabs.dart
View file @
8ca99327
...
...
@@ -691,7 +691,7 @@ class _TabBarState extends State<TabBar> {
// When that happens, automatic transitions of the theme will likely look
// ugly as the indicator color suddenly snaps to white at one end, but it's
// not clear how to avoid that any further.
if
(
color
==
Material
.
of
(
context
).
color
)
if
(
color
.
value
==
Material
.
of
(
context
).
color
.
value
)
color
=
Colors
.
white
;
return
new
UnderlineTabIndicator
(
...
...
packages/flutter/test/material/tabs_test.dart
View file @
8ca99327
...
...
@@ -1721,4 +1721,15 @@ void main() {
));
});
testWidgets
(
'Default tab indicator color is white'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/15958
final
List
<
String
>
tabs
=
<
String
>[
'LEFT'
,
'RIGHT'
];
await
tester
.
pumpWidget
(
buildLeftRightApp
(
tabs:
tabs
,
value:
'LEFT'
));
final
RenderBox
tabBarBox
=
tester
.
firstRenderObject
<
RenderBox
>(
find
.
byType
(
TabBar
));
expect
(
tabBarBox
,
paints
..
line
(
color:
Colors
.
white
,
));
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment