Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8be46a0c
Unverified
Commit
8be46a0c
authored
Jun 18, 2019
by
Jenn Magder
Committed by
GitHub
Jun 18, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Kill compiler process when test does not exit cleanly (#34616)
parent
cc541e67
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
11 additions
and
0 deletions
+11
-0
compile.dart
packages/flutter_tools/lib/src/compile.dart
+1
-0
test_compiler.dart
packages/flutter_tools/lib/src/test/test_compiler.dart
+1
-0
test_compiler_test.dart
packages/flutter_tools/test/test_compiler_test.dart
+9
-0
No files found.
packages/flutter_tools/lib/src/compile.dart
View file @
8be46a0c
...
...
@@ -738,6 +738,7 @@ class ResidentCompiler {
if
(
_server
==
null
)
{
return
0
;
}
printTrace
(
'killing pid
${_server.pid}
'
);
_server
.
kill
();
return
_server
.
exitCode
;
}
...
...
packages/flutter_tools/lib/src/test/test_compiler.dart
View file @
8be46a0c
...
...
@@ -85,6 +85,7 @@ class TestCompiler {
Future
<
void
>
dispose
()
async
{
await
compilerController
.
close
();
await
_shutdown
();
}
/// Create the resident compiler used to compile the test.
...
...
packages/flutter_tools/test/test_compiler_test.dart
View file @
8be46a0c
...
...
@@ -59,6 +59,15 @@ void main() {
expect
(
await
testCompiler
.
compile
(
'test/foo.dart'
),
null
);
expect
(
fs
.
file
(
'test/foo.dart.dill'
).
existsSync
(),
false
);
verify
(
residentCompiler
.
shutdown
()).
called
(
1
);
}));
test
(
'Disposing test compiler shuts down backing compiler'
,
()
=>
testbed
.
run
(()
async
{
testCompiler
.
compiler
=
residentCompiler
;
expect
(
testCompiler
.
compilerController
.
isClosed
,
false
);
await
testCompiler
.
dispose
();
expect
(
testCompiler
.
compilerController
.
isClosed
,
true
);
verify
(
residentCompiler
.
shutdown
()).
called
(
1
);
}));
});
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment