Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8b6b3b62
Commit
8b6b3b62
authored
Jan 14, 2020
by
Prerak Mann
Committed by
Flutter GitHub Bot
Jan 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Passes scrollPhysics (#48342)
parent
ef62092b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
0 deletions
+24
-0
text_form_field.dart
packages/flutter/lib/src/material/text_form_field.dart
+2
-0
text_form_field_test.dart
packages/flutter/test/material/text_form_field_test.dart
+22
-0
No files found.
packages/flutter/lib/src/material/text_form_field.dart
View file @
8b6b3b62
...
...
@@ -124,6 +124,7 @@ class TextFormField extends FormField<String> {
EdgeInsets
scrollPadding
=
const
EdgeInsets
.
all
(
20.0
),
bool
enableInteractiveSelection
=
true
,
InputCounterWidgetBuilder
buildCounter
,
ScrollPhysics
scrollPhysics
,
})
:
assert
(
initialValue
==
null
||
controller
==
null
),
assert
(
textAlign
!=
null
),
assert
(
autofocus
!=
null
),
...
...
@@ -201,6 +202,7 @@ class TextFormField extends FormField<String> {
cursorRadius:
cursorRadius
,
cursorColor:
cursorColor
,
scrollPadding:
scrollPadding
,
scrollPhysics:
scrollPhysics
,
keyboardAppearance:
keyboardAppearance
,
enableInteractiveSelection:
enableInteractiveSelection
,
buildCounter:
buildCounter
,
...
...
packages/flutter/test/material/text_form_field_test.dart
View file @
8b6b3b62
...
...
@@ -32,6 +32,28 @@ void main() {
expect
(
textFieldWidget
.
textAlign
,
alignment
);
});
testWidgets
(
'Passes scrollPhysics to underlying TextField'
,
(
WidgetTester
tester
)
async
{
const
ScrollPhysics
scrollPhysics
=
ScrollPhysics
();
await
tester
.
pumpWidget
(
MaterialApp
(
home:
Material
(
child:
Center
(
child:
TextFormField
(
scrollPhysics:
scrollPhysics
,
),
),
),
),
);
final
Finder
textFieldFinder
=
find
.
byType
(
TextField
);
expect
(
textFieldFinder
,
findsOneWidget
);
final
TextField
textFieldWidget
=
tester
.
widget
(
textFieldFinder
);
expect
(
textFieldWidget
.
scrollPhysics
,
scrollPhysics
);
});
testWidgets
(
'Passes textAlignVertical to underlying TextField'
,
(
WidgetTester
tester
)
async
{
const
TextAlignVertical
textAlignVertical
=
TextAlignVertical
.
bottom
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment