Commit 8b538540 authored by Hixie's avatar Hixie

Clarify why we don't assert that ancestor != null.

Follow-up for #1140.
parent daf5c312
...@@ -1171,8 +1171,13 @@ abstract class RenderObjectWrapper extends Widget { ...@@ -1171,8 +1171,13 @@ abstract class RenderObjectWrapper extends Widget {
assert(() { assert(() {
if (current is ParentDataNode) { if (current is ParentDataNode) {
Widget ancestor = current.parent; Widget ancestor = current.parent;
while (ancestor != null && ancestor is Component) while (ancestor is Component)
ancestor = ancestor.parent; ancestor = ancestor.parent;
// ancestor might be null in two cases:
// - asking for the ancestor of a Widget that has no non-Component
// ancestors between itself and its AbstractWidgetRoot ancestor
// - if the node is just being synced to get its intrinsic
// dimensions, as e.g. MixedViewport does.
if (ancestor != null) if (ancestor != null)
current.debugValidateAncestor(ancestor); current.debugValidateAncestor(ancestor);
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment