Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
89692884
Unverified
Commit
89692884
authored
Nov 08, 2023
by
Christopher Fujino
Committed by
GitHub
Nov 08, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] Fix local engine preview device (#138046)
Fixes
https://github.com/flutter/flutter/issues/137982
parent
e7246898
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
1 deletion
+14
-1
artifacts.dart
packages/flutter_tools/lib/src/artifacts.dart
+6
-1
artifacts_test.dart
...ages/flutter_tools/test/general.shard/artifacts_test.dart
+8
-0
No files found.
packages/flutter_tools/lib/src/artifacts.dart
View file @
89692884
...
...
@@ -1028,7 +1028,12 @@ class CachedLocalEngineArtifacts implements Artifacts {
case
Artifact
.
flutterToolsFileGenerators
:
return
_getFileGeneratorsPath
();
case
Artifact
.
flutterPreviewDevice
:
throw
UnimplementedError
(
'The preview device is not supported with local engine builds'
);
return
_backupCache
.
getArtifactPath
(
artifact
,
platform:
platform
,
mode:
mode
,
environmentType:
environmentType
,
);
}
}
...
...
packages/flutter_tools/test/general.shard/artifacts_test.dart
View file @
89692884
...
...
@@ -329,6 +329,14 @@ void main() {
'snapshots'
,
'frontend_server_aot.dart.snapshot'
)
);
expect
(
artifacts
.
getArtifactPath
(
Artifact
.
flutterPreviewDevice
,
platform:
TargetPlatform
.
windows_x64
,
),
fileSystem
.
path
.
join
(
'root'
,
'bin'
,
'cache'
,
'artifacts'
,
'flutter_preview'
,
'flutter_preview.exe'
),
);
fileSystem
.
file
(
fileSystem
.
path
.
join
(
'/out'
,
'host_debug_unopt'
,
'impellerc'
))
.
createSync
(
recursive:
true
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment