Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
8896f48c
Unverified
Commit
8896f48c
authored
Jun 08, 2019
by
Jonah Williams
Committed by
GitHub
Jun 08, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make running on web spooky (#34084)
parent
317e4cb0
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
9 additions
and
3 deletions
+9
-3
resident_web_runner.dart
packages/flutter_tools/lib/src/resident_web_runner.dart
+9
-3
No files found.
packages/flutter_tools/lib/src/resident_web_runner.dart
View file @
8896f48c
...
@@ -65,14 +65,14 @@ class ResidentWebRunner extends ResidentRunner {
...
@@ -65,14 +65,14 @@ class ResidentWebRunner extends ResidentRunner {
Future
<
void
>
cleanupAfterSignal
()
async
{
Future
<
void
>
cleanupAfterSignal
()
async
{
await
_connection
.
sendCommand
(
'Browser.close'
);
await
_connection
.
sendCommand
(
'Browser.close'
);
_connection
=
null
;
_connection
=
null
;
return
_server
?.
dispose
();
await
_server
?.
dispose
();
}
}
@override
@override
Future
<
void
>
cleanupAtFinish
()
async
{
Future
<
void
>
cleanupAtFinish
()
async
{
await
_connection
?.
sendCommand
(
'Browser.close'
);
await
_connection
?.
sendCommand
(
'Browser.close'
);
_connection
=
null
;
_connection
=
null
;
return
_server
?.
dispose
();
await
_server
?.
dispose
();
}
}
@override
@override
...
@@ -95,6 +95,12 @@ class ResidentWebRunner extends ResidentRunner {
...
@@ -95,6 +95,12 @@ class ResidentWebRunner extends ResidentRunner {
fire
+
terminal
.
bolden
(
rawMessage
),
fire
+
terminal
.
bolden
(
rawMessage
),
TerminalColor
.
red
,
TerminalColor
.
red
,
);
);
const
String
warning
=
'👻 '
;
printStatus
(
warning
*
20
);
printStatus
(
'Warning: Flutter
\'
s support for building web applications is highly experimental.'
);
printStatus
(
'For more information see https://github.com/flutter/flutter/issues/34082.'
);
printStatus
(
warning
*
20
);
printStatus
(
''
);
printStatus
(
message
);
printStatus
(
message
);
const
String
quitMessage
=
'To quit, press "q".'
;
const
String
quitMessage
=
'To quit, press "q".'
;
printStatus
(
'For a more detailed help message, press "h".
$quitMessage
'
);
printStatus
(
'For a more detailed help message, press "h".
$quitMessage
'
);
...
@@ -143,7 +149,7 @@ class ResidentWebRunner extends ResidentRunner {
...
@@ -143,7 +149,7 @@ class ResidentWebRunner extends ResidentRunner {
});
});
_connection
=
await
chromeTab
.
connect
();
_connection
=
await
chromeTab
.
connect
();
_connection
.
onClose
.
listen
((
WipConnection
connection
)
{
_connection
.
onClose
.
listen
((
WipConnection
connection
)
{
appFinished
();
exit
();
});
});
// We don't support the debugging proxy yet.
// We don't support the debugging proxy yet.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment