Unverified Commit 8896f48c authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

make running on web spooky (#34084)

parent 317e4cb0
...@@ -65,14 +65,14 @@ class ResidentWebRunner extends ResidentRunner { ...@@ -65,14 +65,14 @@ class ResidentWebRunner extends ResidentRunner {
Future<void> cleanupAfterSignal() async { Future<void> cleanupAfterSignal() async {
await _connection.sendCommand('Browser.close'); await _connection.sendCommand('Browser.close');
_connection = null; _connection = null;
return _server?.dispose(); await _server?.dispose();
} }
@override @override
Future<void> cleanupAtFinish() async { Future<void> cleanupAtFinish() async {
await _connection?.sendCommand('Browser.close'); await _connection?.sendCommand('Browser.close');
_connection = null; _connection = null;
return _server?.dispose(); await _server?.dispose();
} }
@override @override
...@@ -95,6 +95,12 @@ class ResidentWebRunner extends ResidentRunner { ...@@ -95,6 +95,12 @@ class ResidentWebRunner extends ResidentRunner {
fire + terminal.bolden(rawMessage), fire + terminal.bolden(rawMessage),
TerminalColor.red, TerminalColor.red,
); );
const String warning = '👻 ';
printStatus(warning * 20);
printStatus('Warning: Flutter\'s support for building web applications is highly experimental.');
printStatus('For more information see https://github.com/flutter/flutter/issues/34082.');
printStatus(warning * 20);
printStatus('');
printStatus(message); printStatus(message);
const String quitMessage = 'To quit, press "q".'; const String quitMessage = 'To quit, press "q".';
printStatus('For a more detailed help message, press "h". $quitMessage'); printStatus('For a more detailed help message, press "h". $quitMessage');
...@@ -143,7 +149,7 @@ class ResidentWebRunner extends ResidentRunner { ...@@ -143,7 +149,7 @@ class ResidentWebRunner extends ResidentRunner {
}); });
_connection = await chromeTab.connect(); _connection = await chromeTab.connect();
_connection.onClose.listen((WipConnection connection) { _connection.onClose.listen((WipConnection connection) {
appFinished(); exit();
}); });
// We don't support the debugging proxy yet. // We don't support the debugging proxy yet.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment