Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
888208c1
Unverified
Commit
888208c1
authored
Apr 12, 2022
by
Jenn Magder
Committed by
GitHub
Apr 12, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Disallow `flutter run`-ing on 32-bit development devices (#97339)
parent
b3d1f71d
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
2 deletions
+20
-2
devices.dart
packages/flutter_tools/lib/src/ios/devices.dart
+2
-1
devices_test.dart
...es/flutter_tools/test/general.shard/ios/devices_test.dart
+18
-1
No files found.
packages/flutter_tools/lib/src/ios/devices.dart
View file @
888208c1
...
...
@@ -302,7 +302,8 @@ class IOSDevice extends Device {
}
@override
bool
isSupported
()
=>
true
;
// 32-bit devices are not supported.
bool
isSupported
()
=>
cpuArchitecture
==
DarwinArch
.
arm64
;
@override
Future
<
LaunchResult
>
startApp
(
...
...
packages/flutter_tools/test/general.shard/ios/devices_test.dart
View file @
888208c1
...
...
@@ -64,7 +64,7 @@ void main() {
});
testWithoutContext
(
'successfully instantiates on Mac OS'
,
()
{
IOSDevice
(
final
IOSDevice
device
=
IOSDevice
(
'device-123'
,
iProxy:
IProxy
.
test
(
logger:
logger
,
processManager:
FakeProcessManager
.
any
()),
fileSystem:
fileSystem
,
...
...
@@ -77,6 +77,23 @@ void main() {
cpuArchitecture:
DarwinArch
.
arm64
,
interfaceType:
IOSDeviceConnectionInterface
.
usb
,
);
expect
(
device
.
isSupported
(),
isTrue
);
});
testWithoutContext
(
'32-bit devices are unsupported'
,
()
{
final
IOSDevice
device
=
IOSDevice
(
'device-123'
,
iProxy:
IProxy
.
test
(
logger:
logger
,
processManager:
FakeProcessManager
.
any
()),
fileSystem:
fileSystem
,
logger:
logger
,
platform:
macPlatform
,
iosDeploy:
iosDeploy
,
iMobileDevice:
iMobileDevice
,
name:
'iPhone 1'
,
cpuArchitecture:
DarwinArch
.
armv7
,
interfaceType:
IOSDeviceConnectionInterface
.
usb
,
);
expect
(
device
.
isSupported
(),
isFalse
);
});
testWithoutContext
(
'parses major version'
,
()
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment