Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
82df2353
Unverified
Commit
82df2353
authored
Feb 01, 2023
by
Michael Goderbauer
Committed by
GitHub
Feb 01, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Undo making Flex,Row,Column const (#119669)
parent
dc865659
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
5 deletions
+7
-5
button_bar.dart
packages/flutter/lib/src/material/button_bar.dart
+1
-1
tabs.dart
packages/flutter/lib/src/material/tabs.dart
+1
-1
basic.dart
packages/flutter/lib/src/widgets/basic.dart
+5
-3
No files found.
packages/flutter/lib/src/material/button_bar.dart
View file @
82df2353
...
@@ -233,7 +233,7 @@ class ButtonBar extends StatelessWidget {
...
@@ -233,7 +233,7 @@ class ButtonBar extends StatelessWidget {
class
_ButtonBarRow
extends
Flex
{
class
_ButtonBarRow
extends
Flex
{
/// Creates a button bar that attempts to display in a row, but displays in
/// Creates a button bar that attempts to display in a row, but displays in
/// a column if there is insufficient horizontal space.
/// a column if there is insufficient horizontal space.
const
_ButtonBarRow
({
_ButtonBarRow
({
required
super
.
children
,
required
super
.
children
,
super
.
mainAxisSize
,
super
.
mainAxisSize
,
super
.
mainAxisAlignment
,
super
.
mainAxisAlignment
,
...
...
packages/flutter/lib/src/material/tabs.dart
View file @
82df2353
...
@@ -275,7 +275,7 @@ class _TabLabelBarRenderer extends RenderFlex {
...
@@ -275,7 +275,7 @@ class _TabLabelBarRenderer extends RenderFlex {
// upon layout. The tab widths are only used at paint time (see _IndicatorPainter)
// upon layout. The tab widths are only used at paint time (see _IndicatorPainter)
// or in response to input.
// or in response to input.
class
_TabLabelBar
extends
Flex
{
class
_TabLabelBar
extends
Flex
{
const
_TabLabelBar
({
_TabLabelBar
({
super
.
children
,
super
.
children
,
required
this
.
onPerformLayout
,
required
this
.
onPerformLayout
,
})
:
super
(
})
:
super
(
...
...
packages/flutter/lib/src/widgets/basic.dart
View file @
82df2353
...
@@ -4445,7 +4445,9 @@ class Flex extends MultiChildRenderObjectWidget {
...
@@ -4445,7 +4445,9 @@ class Flex extends MultiChildRenderObjectWidget {
/// to be necessary to decide which direction to lay the children in or to
/// to be necessary to decide which direction to lay the children in or to
/// disambiguate `start` or `end` values for the main or cross axis
/// disambiguate `start` or `end` values for the main or cross axis
/// directions, the [textDirection] must not be null.
/// directions, the [textDirection] must not be null.
const
Flex
({
// TODO(goderbauer): Figure out whether this can be const.
// ignore: prefer_const_constructors_in_immutables
Flex
({
super
.
key
,
super
.
key
,
required
this
.
direction
,
required
this
.
direction
,
this
.
mainAxisAlignment
=
MainAxisAlignment
.
start
,
this
.
mainAxisAlignment
=
MainAxisAlignment
.
start
,
...
@@ -4812,7 +4814,7 @@ class Row extends Flex {
...
@@ -4812,7 +4814,7 @@ class Row extends Flex {
/// unless the row has no children or only one child) or to disambiguate
/// unless the row has no children or only one child) or to disambiguate
/// `start` or `end` values for the [mainAxisAlignment], the [textDirection]
/// `start` or `end` values for the [mainAxisAlignment], the [textDirection]
/// must not be null.
/// must not be null.
const
Row
({
Row
({
super
.
key
,
super
.
key
,
super
.
mainAxisAlignment
,
super
.
mainAxisAlignment
,
super
.
mainAxisSize
,
super
.
mainAxisSize
,
...
@@ -5005,7 +5007,7 @@ class Column extends Flex {
...
@@ -5005,7 +5007,7 @@ class Column extends Flex {
/// any. If there is no ambient directionality, and a text direction is going
/// any. If there is no ambient directionality, and a text direction is going
/// to be necessary to disambiguate `start` or `end` values for the
/// to be necessary to disambiguate `start` or `end` values for the
/// [crossAxisAlignment], the [textDirection] must not be null.
/// [crossAxisAlignment], the [textDirection] must not be null.
const
Column
({
Column
({
super
.
key
,
super
.
key
,
super
.
mainAxisAlignment
,
super
.
mainAxisAlignment
,
super
.
mainAxisSize
,
super
.
mainAxisSize
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment