Skip to content

F
Front-End
Unverified Commit 80cee598 authored by stuartmorgan's avatar stuartmorgan Committed by GitHub
Browse files
Options

Don't rethrow Dart plugin registration exceptions (#122111) 

Don't rethrow Dart plugin registration exceptions
parent c0ddbf12
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 9 deletions
packages/flutter_tools/lib/src/flutter_plugins.dart
View file @ 80cee598
...@@ -703,7 +703,6 @@ const String _dartPluginRegisterWith = r''' ...@@ -703,7 +703,6 @@ const String _dartPluginRegisterWith = r'''
'`{{pluginName}}` threw an error: $err. ' '`{{pluginName}}` threw an error: $err. '
'The app may not function as expected until you remove this plugin from pubspec.yaml' 'The app may not function as expected until you remove this plugin from pubspec.yaml'
); );
rethrow;
} }
'''; ''';
......
packages/flutter_tools/test/general.shard/build_system/targets/dart_plugin_registrant_test.dart
View file @ 80cee598
...@@ -257,7 +257,6 @@ void main() { ...@@ -257,7 +257,6 @@ void main() {
" '`path_provider_linux` threw an error: \$err. '\n" " '`path_provider_linux` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' } else if (Platform.isMacOS) {\n' ' } else if (Platform.isMacOS) {\n'
...@@ -385,7 +384,6 @@ void main() { ...@@ -385,7 +384,6 @@ void main() {
" '`path_provider_linux` threw an error: \$err. '\n" " '`path_provider_linux` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' } else if (Platform.isMacOS) {\n' ' } else if (Platform.isMacOS) {\n'
......
packages/flutter_tools/test/general.shard/dart_plugin_test.dart
View file @ 80cee598
...@@ -807,7 +807,6 @@ void main() { ...@@ -807,7 +807,6 @@ void main() {
" '`url_launcher_android` threw an error: \$err. '\n" " '`url_launcher_android` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' } else if (Platform.isIOS) {\n' ' } else if (Platform.isIOS) {\n'
...@@ -818,7 +817,6 @@ void main() { ...@@ -818,7 +817,6 @@ void main() {
" '`url_launcher_ios` threw an error: \$err. '\n" " '`url_launcher_ios` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' } else if (Platform.isLinux) {\n' ' } else if (Platform.isLinux) {\n'
...@@ -829,7 +827,6 @@ void main() { ...@@ -829,7 +827,6 @@ void main() {
" '`url_launcher_linux` threw an error: \$err. '\n" " '`url_launcher_linux` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' } else if (Platform.isMacOS) {\n' ' } else if (Platform.isMacOS) {\n'
...@@ -840,7 +837,6 @@ void main() { ...@@ -840,7 +837,6 @@ void main() {
" '`awesome_macos` threw an error: \$err. '\n" " '`awesome_macos` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' try {\n' ' try {\n'
...@@ -850,7 +846,6 @@ void main() { ...@@ -850,7 +846,6 @@ void main() {
" '`url_launcher_macos` threw an error: \$err. '\n" " '`url_launcher_macos` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' } else if (Platform.isWindows) {\n' ' } else if (Platform.isWindows) {\n'
...@@ -861,7 +856,6 @@ void main() { ...@@ -861,7 +856,6 @@ void main() {
" '`url_launcher_windows` threw an error: \$err. '\n" " '`url_launcher_windows` threw an error: \$err. '\n"
" 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n" " 'The app may not function as expected until you remove this plugin from pubspec.yaml'\n"
' );\n' ' );\n'
' rethrow;\n'
' }\n' ' }\n'
'\n' '\n'
' }\n' ' }\n'
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab