Unverified Commit 8046e133 authored by Jackson Gardner's avatar Jackson Gardner Committed by GitHub

Run benchmarks with `--omit-type-checks` (#131102)

We've decided to use the `--omit-type-checks` flag for our dart2wasm benchmarks. Right now, many of the benchmark results are dominated by type checks and most of what we are actually trying to measure get drowned out in the noise.
parent d4d57546
...@@ -1079,7 +1079,6 @@ targets: ...@@ -1079,7 +1079,6 @@ targets:
- name: Linux web_benchmarks_html - name: Linux web_benchmarks_html
recipe: devicelab/devicelab_drone recipe: devicelab/devicelab_drone
presubmit: false
timeout: 60 timeout: 60
properties: properties:
dependencies: >- dependencies: >-
...@@ -1096,7 +1095,6 @@ targets: ...@@ -1096,7 +1095,6 @@ targets:
- .ci.yaml - .ci.yaml
- name: Linux web_benchmarks_skwasm - name: Linux web_benchmarks_skwasm
bringup: true
recipe: devicelab/devicelab_drone recipe: devicelab/devicelab_drone
presubmit: false presubmit: false
timeout: 60 timeout: 60
......
...@@ -36,6 +36,7 @@ Future<TaskResult> runWebBenchmark(WebBenchmarkOptions benchmarkOptions) async { ...@@ -36,6 +36,7 @@ Future<TaskResult> runWebBenchmark(WebBenchmarkOptions benchmarkOptions) async {
if (benchmarkOptions.useWasm) ...<String>[ if (benchmarkOptions.useWasm) ...<String>[
'--wasm', '--wasm',
'--wasm-opt=debug', '--wasm-opt=debug',
'--omit-type-checks',
], ],
'--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true', '--dart-define=FLUTTER_WEB_ENABLE_PROFILING=true',
'--web-renderer=${benchmarkOptions.webRenderer}', '--web-renderer=${benchmarkOptions.webRenderer}',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment