Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7e59a9e8
Commit
7e59a9e8
authored
Feb 22, 2016
by
Chinmay Garde
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Address issues raised in PR #2047
parent
6ab25977
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
9 deletions
+13
-9
ios_workflow.dart
packages/flutter_tools/lib/src/ios/ios_workflow.dart
+1
-5
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+12
-4
No files found.
packages/flutter_tools/lib/src/ios/ios_workflow.dart
View file @
7e59a9e8
...
...
@@ -32,11 +32,7 @@ class IOSWorkflow extends Workflow {
};
Function
_xcodeVersionSatisfactory
=
()
{
if
(
xcode
.
isInstalledAndMeetsVersionCheck
)
{
return
ValidationType
.
installed
;
}
return
ValidationType
.
missing
;
return
xcode
.
isInstalledAndMeetsVersionCheck
?
ValidationType
.
installed
:
ValidationType
.
missing
;
};
Function
_xcodeEulaSigned
=
()
{
...
...
packages/flutter_tools/lib/src/ios/mac.dart
View file @
7e59a9e8
...
...
@@ -73,17 +73,25 @@ class XCode {
int
major
=
int
.
parse
(
components
[
0
]);
int
minor
=
components
.
length
==
1
?
0
:
int
.
parse
(
components
[
1
]);
_xcodeVersionSatisfactory
=
major
>=
kXcodeRequiredVersionMajor
&&
minor
>=
kXcodeRequiredVersionMinor
;
return
_xcodeVersionSatisfactory
;
_xcodeVersionSatisfactory
=
_xcodeVersionCheckValid
(
major
,
minor
);
}
catch
(
error
)
{
_xcodeVersionSatisfactory
=
false
;
return
false
;
}
return
false
;
return
_xcodeVersionSatisfactory
;
}
}
bool
_xcodeVersionCheckValid
(
int
major
,
int
minor
)
{
if
(
major
>
kXcodeRequiredVersionMajor
)
return
true
;
if
(
major
==
kXcodeRequiredVersionMajor
)
return
minor
>=
kXcodeRequiredVersionMinor
;
return
false
;
}
Future
<
bool
>
buildIOSXcodeProject
(
ApplicationPackage
app
,
{
bool
buildForDevice
})
async
{
String
flutterProjectPath
=
Directory
.
current
.
path
;
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment