Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7e017d31
Unverified
Commit
7e017d31
authored
Mar 02, 2021
by
Michael Goderbauer
Committed by
GitHub
Mar 02, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Enable file_names and package_names lints (#77087)
parent
6250613e
Changes
9
Hide whitespace changes
Inline
Side-by-side
Showing
9 changed files
with
12 additions
and
12 deletions
+12
-12
analysis_options.yaml
analysis_options.yaml
+2
-2
main.dart
dev/benchmarks/macrobenchmarks/lib/main.dart
+1
-1
fullscreen_textfield.dart
...chmarks/macrobenchmarks/lib/src/fullscreen_textfield.dart
+0
-0
analyze.dart
dev/bots/analyze.dart
+1
-1
analyze_sample_code.dart
dev/bots/analyze_sample_code.dart
+1
-1
known_broken_documentation.dart
...ze-sample-code-test-input/known_broken_documentation.dart
+1
-1
analyze_sample_code_test.dart
dev/bots/test/analyze_sample_code_test.dart
+2
-2
README.md
dev/snippets/README.md
+3
-3
semantics_tester_generate_test_semantics_expression_for_current_semantics_tree_test.dart
...semantics_expression_for_current_semantics_tree_test.dart
+1
-1
No files found.
analysis_options.yaml
View file @
7e017d31
...
@@ -113,7 +113,7 @@ linter:
...
@@ -113,7 +113,7 @@ linter:
-
empty_constructor_bodies
-
empty_constructor_bodies
-
empty_statements
-
empty_statements
-
exhaustive_cases
-
exhaustive_cases
# - file_names # not yet tested
-
file_names
-
flutter_style_todos
-
flutter_style_todos
-
hash_and_equals
-
hash_and_equals
-
implementation_imports
-
implementation_imports
...
@@ -140,7 +140,7 @@ linter:
...
@@ -140,7 +140,7 @@ linter:
# - only_throw_errors # https://github.com/flutter/flutter/issues/5792
# - only_throw_errors # https://github.com/flutter/flutter/issues/5792
-
overridden_fields
-
overridden_fields
-
package_api_docs
-
package_api_docs
# - package_names # non conforming packages in sdk
-
package_names
-
package_prefixed_library_names
-
package_prefixed_library_names
# - parameter_assignments # we do this commonly
# - parameter_assignments # we do this commonly
-
prefer_adjacent_string_concatenation
-
prefer_adjacent_string_concatenation
...
...
dev/benchmarks/macrobenchmarks/lib/main.dart
View file @
7e017d31
...
@@ -12,7 +12,7 @@ import 'src/color_filter_and_fade.dart';
...
@@ -12,7 +12,7 @@ import 'src/color_filter_and_fade.dart';
import
'src/cubic_bezier.dart'
;
import
'src/cubic_bezier.dart'
;
import
'src/cull_opacity.dart'
;
import
'src/cull_opacity.dart'
;
import
'src/filtered_child_animation.dart'
;
import
'src/filtered_child_animation.dart'
;
import
'src/fullscreen
TextF
ield.dart'
;
import
'src/fullscreen
_textf
ield.dart'
;
import
'src/heavy_grid_view.dart'
;
import
'src/heavy_grid_view.dart'
;
import
'src/large_image_changer.dart'
;
import
'src/large_image_changer.dart'
;
import
'src/large_images.dart'
;
import
'src/large_images.dart'
;
...
...
dev/benchmarks/macrobenchmarks/lib/src/fullscreen
TextF
ield.dart
→
dev/benchmarks/macrobenchmarks/lib/src/fullscreen
_textf
ield.dart
View file @
7e017d31
File moved
dev/bots/analyze.dart
View file @
7e017d31
...
@@ -99,7 +99,7 @@ Future<void> run(List<String> arguments) async {
...
@@ -99,7 +99,7 @@ Future<void> run(List<String> arguments) async {
// Analyze all the sample code in the repo
// Analyze all the sample code in the repo
print
(
'
$clock
Sample code...'
);
print
(
'
$clock
Sample code...'
);
await
runCommand
(
dart
,
await
runCommand
(
dart
,
<
String
>[
path
.
join
(
flutterRoot
,
'dev'
,
'bots'
,
'analyze
-sample-
code.dart'
)],
<
String
>[
path
.
join
(
flutterRoot
,
'dev'
,
'bots'
,
'analyze
_sample_
code.dart'
)],
workingDirectory:
flutterRoot
,
workingDirectory:
flutterRoot
,
);
);
...
...
dev/bots/analyze
-sample-
code.dart
→
dev/bots/analyze
_sample_
code.dart
View file @
7e017d31
...
@@ -5,7 +5,7 @@
...
@@ -5,7 +5,7 @@
// See ../snippets/README.md for documentation.
// See ../snippets/README.md for documentation.
// To run this, from the root of the Flutter repository:
// To run this, from the root of the Flutter repository:
// bin/cache/dart-sdk/bin/dart dev/bots/analyze
-sample-
code.dart
// bin/cache/dart-sdk/bin/dart dev/bots/analyze
_sample_
code.dart
import
'dart:io'
;
import
'dart:io'
;
...
...
dev/bots/test/analyze-sample-code-test-input/known_broken_documentation.dart
View file @
7e017d31
...
@@ -2,7 +2,7 @@
...
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// found in the LICENSE file.
// This file is used by ../analyze
-sample-
code_test.dart, which depends on the
// This file is used by ../analyze
_sample_
code_test.dart, which depends on the
// precise contents (including especially the comments) of this file.
// precise contents (including especially the comments) of this file.
// Examples can assume:
// Examples can assume:
...
...
dev/bots/test/analyze
-sample-
code_test.dart
→
dev/bots/test/analyze
_sample_
code_test.dart
View file @
7e017d31
...
@@ -7,10 +7,10 @@ import 'dart:io';
...
@@ -7,10 +7,10 @@ import 'dart:io';
import
'common.dart'
;
import
'common.dart'
;
void
main
(
)
{
void
main
(
)
{
test
(
'analyze
-sample-
code'
,
()
{
test
(
'analyze
_sample_
code'
,
()
{
final
ProcessResult
process
=
Process
.
runSync
(
final
ProcessResult
process
=
Process
.
runSync
(
'../../bin/cache/dart-sdk/bin/dart'
,
'../../bin/cache/dart-sdk/bin/dart'
,
<
String
>[
'analyze
-sample-
code.dart'
,
'test/analyze-sample-code-test-input'
],
<
String
>[
'analyze
_sample_
code.dart'
,
'test/analyze-sample-code-test-input'
],
);
);
final
List
<
String
>
stdoutLines
=
process
.
stdout
.
toString
().
split
(
'
\n
'
);
final
List
<
String
>
stdoutLines
=
process
.
stdout
.
toString
().
split
(
'
\n
'
);
final
List
<
String
>
stderrLines
=
process
.
stderr
.
toString
().
split
(
'
\n
'
)
final
List
<
String
>
stderrLines
=
process
.
stderr
.
toString
().
split
(
'
\n
'
)
...
...
dev/snippets/README.md
View file @
7e017d31
...
@@ -63,7 +63,7 @@ when generating the HTML to put into the Dart docs.
...
@@ -63,7 +63,7 @@ when generating the HTML to put into the Dart docs.
#### Analysis
#### Analysis
The
`../bots/analyze
-sample-
code.dart`
script finds code inside the
`@tool
The
`../bots/analyze
_sample_
code.dart`
script finds code inside the
`@tool
snippet`
sections and uses the Dart analyzer to check them.
snippet`
sections and uses the Dart analyzer to check them.
There are several kinds of sample code you can specify:
There are several kinds of sample code you can specify:
...
@@ -165,7 +165,7 @@ For more information about how to create, use, or update templates, see
...
@@ -165,7 +165,7 @@ For more information about how to create, use, or update templates, see
#### Analysis
#### Analysis
The
`../bots/analyze
-sample-
code.dart`
script finds code inside the
`@tool
The
`../bots/analyze
_sample_
code.dart`
script finds code inside the
`@tool
sample`
sections and uses the Dart analyzer to check them after applying the
sample`
sections and uses the Dart analyzer to check them after applying the
specified template.
specified template.
...
@@ -222,7 +222,7 @@ generating the entire docs output takes a long time.
...
@@ -222,7 +222,7 @@ generating the entire docs output takes a long time.
Instead, you can run the analysis locally with this command from the Flutter root:
Instead, you can run the analysis locally with this command from the Flutter root:
```
```
TMPDIR=/tmp bin/cache/dart-sdk/bin/dart dev/bots/analyze
-sample-
code.dart --temp=samples
TMPDIR=/tmp bin/cache/dart-sdk/bin/dart dev/bots/analyze
_sample_
code.dart --temp=samples
```
```
This will analyze the samples, and leave the generated files in
`/tmp/samples`
This will analyze the samples, and leave the generated files in
`/tmp/samples`
...
...
packages/flutter/test/widgets/semantics_tester_generate
TestSemanticsExpressionForCurrentSemanticsT
ree_test.dart
→
packages/flutter/test/widgets/semantics_tester_generate
_test_semantics_expression_for_current_semantics_t
ree_test.dart
View file @
7e017d31
...
@@ -67,7 +67,7 @@ void _tests() {
...
@@ -67,7 +67,7 @@ void _tests() {
if
(
childSearch
!=
null
)
{
if
(
childSearch
!=
null
)
{
return
childSearch
;
return
childSearch
;
}
}
}
else
if
(
entity
is
File
&&
entity
.
path
.
endsWith
(
'semantics_tester_generate
TestSemanticsExpressionForCurrentSemanticsT
ree_test.dart'
))
{
}
else
if
(
entity
is
File
&&
entity
.
path
.
endsWith
(
'semantics_tester_generate
_test_semantics_expression_for_current_semantics_t
ree_test.dart'
))
{
return
entity
;
return
entity
;
}
}
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment