Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7de1e225
Unverified
Commit
7de1e225
authored
Jan 13, 2022
by
Spt
Committed by
GitHub
Jan 13, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix rsync output utf8decode bug (#95881)
parent
046dde3d
Changes
6
Hide whitespace changes
Inline
Side-by-side
Showing
6 changed files
with
8 additions
and
1 deletion
+8
-1
xcode_backend.dart
packages/flutter_tools/bin/xcode_backend.dart
+1
-0
os.dart
packages/flutter_tools/lib/src/base/os.dart
+2
-1
mac.dart
packages/flutter_tools/lib/src/ios/mac.dart
+1
-0
build_ios_test.dart
...er_tools/test/commands.shard/hermetic/build_ios_test.dart
+1
-0
os_test.dart
packages/flutter_tools/test/general.shard/base/os_test.dart
+2
-0
ios_device_start_nonprebuilt_test.dart
.../general.shard/ios/ios_device_start_nonprebuilt_test.dart
+1
-0
No files found.
packages/flutter_tools/bin/xcode_backend.dart
View file @
7de1e225
...
...
@@ -190,6 +190,7 @@ class Context {
runSync
(
'rsync'
,
<
String
>[
'-8'
,
// Avoid mangling filenames with encodings that do not match the current locale.
'-av'
,
'--delete'
,
'--filter'
,
...
...
packages/flutter_tools/lib/src/base/os.dart
View file @
7de1e225
...
...
@@ -451,8 +451,9 @@ class _MacOSUtils extends _PosixUtils {
);
for
(
final
FileSystemEntity
unzippedFile
in
tempDirectory
.
listSync
(
followLinks:
false
))
{
// rsync --delete the unzipped files so files removed from the archive are also removed from the target.
// Add the '-8' parameter to avoid mangling filenames with encodings that do not match the current locale.
_processUtils
.
runSync
(
<
String
>[
'rsync'
,
'-av'
,
'--delete'
,
unzippedFile
.
path
,
targetDirectory
.
path
],
<
String
>[
'rsync'
,
'-
8'
,
'-
av'
,
'--delete'
,
unzippedFile
.
path
,
targetDirectory
.
path
],
throwOnError:
true
,
verboseExceptions:
true
,
);
...
...
packages/flutter_tools/lib/src/ios/mac.dart
View file @
7de1e225
...
...
@@ -462,6 +462,7 @@ Future<XcodeBuildResult> buildXcodeProject({
await
globals
.
processUtils
.
run
(
<
String
>[
'rsync'
,
'-8'
,
// Avoid mangling filenames with encodings that do not match the current locale.
'-av'
,
'--delete'
,
expectedOutputDirectory
,
...
...
packages/flutter_tools/test/commands.shard/hermetic/build_ios_test.dart
View file @
7de1e225
...
...
@@ -84,6 +84,7 @@ void main() {
return
FakeCommand
(
command:
const
<
String
>[
'rsync'
,
'-8'
,
'-av'
,
'--delete'
,
'build/ios/Release-iphoneos/Runner.app'
,
...
...
packages/flutter_tools/test/general.shard/base/os_test.dart
View file @
7de1e225
...
...
@@ -586,6 +586,7 @@ void main() {
),
FakeCommand
(
command:
<
String
>[
'rsync'
,
'-8'
,
'-av'
,
'--delete'
,
tempDirectory
.
childDirectory
(
'dirA'
).
path
,
...
...
@@ -593,6 +594,7 @@ void main() {
]),
FakeCommand
(
command:
<
String
>[
'rsync'
,
'-8'
,
'-av'
,
'--delete'
,
tempDirectory
.
childDirectory
(
'dirB'
).
path
,
...
...
packages/flutter_tools/test/general.shard/ios/ios_device_start_nonprebuilt_test.dart
View file @
7de1e225
...
...
@@ -188,6 +188,7 @@ void main() {
processManager
.
addCommand
(
const
FakeCommand
(
command:
kRunReleaseArgs
));
processManager
.
addCommand
(
const
FakeCommand
(
command:
<
String
>[
'rsync'
,
'-8'
,
'-av'
,
'--delete'
,
'build/ios/Release-iphoneos/My Super Awesome App.app'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment