Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7c24ebc7
Unverified
Commit
7c24ebc7
authored
Feb 12, 2020
by
Jenn Magder
Committed by
GitHub
Feb 12, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Map arm64e devices to arm64 devices (#50612)
parent
781cd4d8
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
10 additions
and
1 deletion
+10
-1
build.dart
packages/flutter_tools/lib/src/base/build.dart
+1
-1
build_info.dart
packages/flutter_tools/lib/src/build_info.dart
+1
-0
build_info_test.dart
...ges/flutter_tools/test/general.shard/build_info_test.dart
+8
-0
No files found.
packages/flutter_tools/lib/src/base/build.dart
View file @
7c24ebc7
...
...
@@ -142,7 +142,7 @@ class AOTSnapshotter {
genSnapshotArgs
.
add
(
'--no-use-integer-division'
);
}
// The name of the debug file must contain additonal information about
// The name of the debug file must contain addit
i
onal information about
// the architecture, since a single build command may produce
// multiple debug files.
final
String
archName
=
getNameForTargetPlatform
(
platform
,
darwinArch:
darwinArch
);
...
...
packages/flutter_tools/lib/src/build_info.dart
View file @
7c24ebc7
...
...
@@ -390,6 +390,7 @@ DarwinArch getIOSArchForName(String arch) {
case
'armv7'
:
return
DarwinArch
.
armv7
;
case
'arm64'
:
case
'arm64e'
:
// iPhone XS/XS Max/XR and higher. arm64 runs on arm64e devices.
return
DarwinArch
.
arm64
;
case
'x86_64'
:
return
DarwinArch
.
x86_64
;
...
...
packages/flutter_tools/test/general.shard/build_info_test.dart
View file @
7c24ebc7
...
...
@@ -85,4 +85,12 @@ void main() {
expect
(
getNameForTargetPlatform
(
TargetPlatform
.
ios
,
darwinArch:
DarwinArch
.
x86_64
),
'ios-x86_64'
);
expect
(
getNameForTargetPlatform
(
TargetPlatform
.
android
),
isNot
(
contains
(
'ios'
)));
});
test
(
'getIOSArchForName on Darwin arches'
,
()
{
expect
(
getIOSArchForName
(
'armv7'
),
DarwinArch
.
armv7
);
expect
(
getIOSArchForName
(
'arm64'
),
DarwinArch
.
arm64
);
expect
(
getIOSArchForName
(
'arm64e'
),
DarwinArch
.
arm64
);
expect
(
getIOSArchForName
(
'x86_64'
),
DarwinArch
.
x86_64
);
expect
(()
=>
getIOSArchForName
(
'bogus'
),
throwsAssertionError
);
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment