Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
7a88eb97
Unverified
Commit
7a88eb97
authored
Mar 23, 2021
by
Shi-Hao Hong
Committed by
GitHub
Mar 23, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Typo fixes (#78755)
parent
2eca1f40
Changes
12
Hide whitespace changes
Inline
Side-by-side
Showing
12 changed files
with
17 additions
and
18 deletions
+17
-18
README.md
dev/bots/README.md
+1
-1
sliding_segmented_control.dart
.../flutter/lib/src/cupertino/sliding_segmented_control.dart
+1
-1
navigation_rail.dart
packages/flutter/lib/src/material/navigation_rail.dart
+2
-2
drag_target.dart
packages/flutter/lib/src/widgets/drag_target.dart
+1
-1
router.dart
packages/flutter/lib/src/widgets/router.dart
+2
-2
popup_menu_test.dart
packages/flutter/test/material/popup_menu_test.dart
+0
-1
scrollbar_theme_test.dart
packages/flutter/test/material/scrollbar_theme_test.dart
+1
-1
test_private.dart
packages/flutter/test_private/bin/test_private.dart
+1
-1
material_en.arb
packages/flutter_localizations/lib/src/l10n/material_en.arb
+3
-3
accessibility.dart
packages/flutter_test/lib/src/accessibility.dart
+1
-1
flutter.gradle
packages/flutter_tools/gradle/flutter.gradle
+3
-3
persistent_tool_state.dart
packages/flutter_tools/lib/src/persistent_tool_state.dart
+1
-1
No files found.
dev/bots/README.md
View file @
7a88eb97
...
@@ -4,7 +4,7 @@ This directory exists to support building Flutter on our build infrastructure.
...
@@ -4,7 +4,7 @@ This directory exists to support building Flutter on our build infrastructure.
Flutter build results are available at:
Flutter build results are available at:
*
https://flutter-dashboard.appspot.com/#/build
*
https://flutter-dashboard.appspot.com/#/build
-
Aggregate dashboard of the
the
separate CI systems used by Flutter.
-
Aggregate dashboard of the separate CI systems used by Flutter.
*
https://cirrus-ci.com/github/flutter/flutter/master
*
https://cirrus-ci.com/github/flutter/flutter/master
-
Testing is done on PRs and submitted changes on GitHub.
-
Testing is done on PRs and submitted changes on GitHub.
*
https://ci.chromium.org/p/flutter/
*
https://ci.chromium.org/p/flutter/
...
...
packages/flutter/lib/src/cupertino/sliding_segmented_control.dart
View file @
7a88eb97
...
@@ -976,7 +976,7 @@ class _RenderSegmentedControl<T> extends RenderBox
...
@@ -976,7 +976,7 @@ class _RenderSegmentedControl<T> extends RenderBox
// This method is used to convert the original unscaled thumb rect painted in
// This method is used to convert the original unscaled thumb rect painted in
// the previous frame, to a Rect that is within the valid boundary defined by
// the previous frame, to a Rect that is within the valid boundary defined by
// the
the
child segments.
// the child segments.
//
//
// The overall size does not include that of the thumb. That is, if the thumb
// The overall size does not include that of the thumb. That is, if the thumb
// is located at the first or the last segment, the thumb can get cut off if
// is located at the first or the last segment, the thumb can get cut off if
...
...
packages/flutter/lib/src/material/navigation_rail.dart
View file @
7a88eb97
...
@@ -287,7 +287,7 @@ class NavigationRail extends StatefulWidget {
...
@@ -287,7 +287,7 @@ class NavigationRail extends StatefulWidget {
/// a copy of the [IconThemeData.fallback] with a custom [NavigationRail]
/// a copy of the [IconThemeData.fallback] with a custom [NavigationRail]
/// specific color will be used.
/// specific color will be used.
///
///
/// The default value is
Is
the [Theme]'s [ThemeData.iconTheme] with a color
/// The default value is the [Theme]'s [ThemeData.iconTheme] with a color
/// of the [Theme]'s [ColorScheme.onSurface] with an opacity of 0.64.
/// of the [Theme]'s [ColorScheme.onSurface] with an opacity of 0.64.
/// Properties from this icon theme, or
/// Properties from this icon theme, or
/// [NavigationRailThemeData.unselectedIconTheme] if this is null, are
/// [NavigationRailThemeData.unselectedIconTheme] if this is null, are
...
@@ -299,7 +299,7 @@ class NavigationRail extends StatefulWidget {
...
@@ -299,7 +299,7 @@ class NavigationRail extends StatefulWidget {
/// When a [NavigationRailDestination] is not selected,
/// When a [NavigationRailDestination] is not selected,
/// [unselectedIconTheme] will be used.
/// [unselectedIconTheme] will be used.
///
///
/// The default value is
Is
the [Theme]'s [ThemeData.iconTheme] with a color
/// The default value is the [Theme]'s [ThemeData.iconTheme] with a color
/// of the [Theme]'s [ColorScheme.primary]. Properties from this icon theme,
/// of the [Theme]'s [ColorScheme.primary]. Properties from this icon theme,
/// or [NavigationRailThemeData.selectedIconTheme] if this is null, are
/// or [NavigationRailThemeData.selectedIconTheme] if this is null, are
/// merged into the defaults.
/// merged into the defaults.
...
...
packages/flutter/lib/src/widgets/drag_target.dart
View file @
7a88eb97
...
@@ -296,7 +296,7 @@ class Draggable<T extends Object> extends StatefulWidget {
...
@@ -296,7 +296,7 @@ class Draggable<T extends Object> extends StatefulWidget {
)
)
final
DragAnchor
dragAnchor
;
final
DragAnchor
dragAnchor
;
/// A strategy that is used by this draggable to get the
the
anchor offset when it is dragged.
/// A strategy that is used by this draggable to get the anchor offset when it is dragged.
///
///
/// The anchor offset refers to the distance between the users' fingers and the [feedback] widget when this draggable is dragged.
/// The anchor offset refers to the distance between the users' fingers and the [feedback] widget when this draggable is dragged.
///
///
...
...
packages/flutter/lib/src/widgets/router.dart
View file @
7a88eb97
...
@@ -146,7 +146,7 @@ class RouteInformation {
...
@@ -146,7 +146,7 @@ class RouteInformation {
/// considered unusual for these delegates to change during the lifetime of the
/// considered unusual for these delegates to change during the lifetime of the
/// [Router].
/// [Router].
///
///
/// If the [Router] itself is disposed while an a
n a
synchronous operation is in
/// If the [Router] itself is disposed while an asynchronous operation is in
/// progress, all active asynchronous operations will have their results
/// progress, all active asynchronous operations will have their results
/// discarded also.
/// discarded also.
///
///
...
@@ -1108,7 +1108,7 @@ abstract class RouterDelegate<T> extends Listenable {
...
@@ -1108,7 +1108,7 @@ abstract class RouterDelegate<T> extends Listenable {
/// When overriding this method, the configuration returned by this getter
/// When overriding this method, the configuration returned by this getter
/// must be able to construct the current app state and build the widget
/// must be able to construct the current app state and build the widget
/// with the same configuration in the [build] method if it is passed back
/// with the same configuration in the [build] method if it is passed back
/// to the
the
[setNewRoutePath]. Otherwise, the browser backward and forward
/// to the [setNewRoutePath]. Otherwise, the browser backward and forward
/// buttons will not work properly.
/// buttons will not work properly.
///
///
/// By default, this getter returns null, which prevents the [Router] from
/// By default, this getter returns null, which prevents the [Router] from
...
...
packages/flutter/test/material/popup_menu_test.dart
View file @
7a88eb97
...
@@ -1490,7 +1490,6 @@ void main() {
...
@@ -1490,7 +1490,6 @@ void main() {
expect
(
tester
.
widget
<
Container
>(
find
.
widgetWithText
(
Container
,
'Item 3'
)).
padding
,
const
EdgeInsets
.
all
(
20
));
expect
(
tester
.
widget
<
Container
>(
find
.
widgetWithText
(
Container
,
'Item 3'
)).
padding
,
const
EdgeInsets
.
all
(
20
));
});
});
testWidgets
(
'Update PopupMenuItem layout while the menu is visible'
,
(
WidgetTester
tester
)
async
{
testWidgets
(
'Update PopupMenuItem layout while the menu is visible'
,
(
WidgetTester
tester
)
async
{
final
Key
popupMenuButtonKey
=
UniqueKey
();
final
Key
popupMenuButtonKey
=
UniqueKey
();
final
Type
menuItemType
=
const
PopupMenuItem
<
String
>(
child:
Text
(
'item'
)).
runtimeType
;
final
Type
menuItemType
=
const
PopupMenuItem
<
String
>(
child:
Text
(
'item'
)).
runtimeType
;
...
...
packages/flutter/test/material/scrollbar_theme_test.dart
View file @
7a88eb97
...
@@ -11,7 +11,7 @@ import 'package:flutter_test/flutter_test.dart';
...
@@ -11,7 +11,7 @@ import 'package:flutter_test/flutter_test.dart';
import
'../rendering/mock_canvas.dart'
;
import
'../rendering/mock_canvas.dart'
;
// The const represents the
the
starting position of the scrollbar thumb for
// The const represents the starting position of the scrollbar thumb for
// the below tests. The thumb is 90 pixels long, and 8 pixels wide, with a 2
// the below tests. The thumb is 90 pixels long, and 8 pixels wide, with a 2
// pixel margin to the right edge of the viewport.
// pixel margin to the right edge of the viewport.
const
Rect
_kMaterialDesignInitialThumbRect
=
Rect
.
fromLTRB
(
790.0
,
0.0
,
798.0
,
90.0
);
const
Rect
_kMaterialDesignInitialThumbRect
=
Rect
.
fromLTRB
(
790.0
,
0.0
,
798.0
,
90.0
);
...
...
packages/flutter/test_private/bin/test_private.dart
View file @
7a88eb97
...
@@ -175,7 +175,7 @@ class TestCase {
...
@@ -175,7 +175,7 @@ class TestCase {
return
false
;
return
false
;
}
}
}
}
// Copy the test files into the t
he t
mpdir's lib directory.
// Copy the test files into the tmpdir's lib directory.
for
(
final
File
file
in
tests
)
{
for
(
final
File
file
in
tests
)
{
String
destination
=
tmpdir
.
path
;
String
destination
=
tmpdir
.
path
;
try
{
try
{
...
...
packages/flutter_localizations/lib/src/l10n/material_en.arb
View file @
7a88eb97
...
@@ -248,17 +248,17 @@
...
@@ -248,17 +248,17 @@
"dateInputLabel"
:
"Enter Date"
,
"dateInputLabel"
:
"Enter Date"
,
"@dateInputLabel"
:
{
"@dateInputLabel"
:
{
"description"
:
"The label used to describe the input text field used in
in
the date picker."
"description"
:
"The label used to describe the input text field used in the date picker."
},
},
"dateRangeStartLabel"
:
"Start Date"
,
"dateRangeStartLabel"
:
"Start Date"
,
"@dateRangeStartLabel"
:
{
"@dateRangeStartLabel"
:
{
"description"
:
"The label used to describe the starting date input text field used in
in
the date range picker."
"description"
:
"The label used to describe the starting date input text field used in the date range picker."
},
},
"dateRangeEndLabel"
:
"End Date"
,
"dateRangeEndLabel"
:
"End Date"
,
"@dateRangeEndLabel"
:
{
"@dateRangeEndLabel"
:
{
"description"
:
"The label used to describe the ending date input text field used in
in
the date range picker."
"description"
:
"The label used to describe the ending date input text field used in the date range picker."
},
},
"dateRangeStartDateSemanticLabel"
:
"Start date $fullDate"
,
"dateRangeStartDateSemanticLabel"
:
"Start date $fullDate"
,
...
...
packages/flutter_test/lib/src/accessibility.dart
View file @
7a88eb97
...
@@ -436,7 +436,7 @@ class _ContrastReport {
...
@@ -436,7 +436,7 @@ class _ContrastReport {
///
///
/// Given a list of integers [colors], each representing the color of a pixel
/// Given a list of integers [colors], each representing the color of a pixel
/// on a part of the screen, generates a contrast ratio report.
/// on a part of the screen, generates a contrast ratio report.
/// Each colors is given in
in
ARGB format, as is the parameter for the
/// Each colors is given in ARGB format, as is the parameter for the
/// constructor [Color].
/// constructor [Color].
///
///
/// The contrast ratio of the most frequent light color and the most
/// The contrast ratio of the most frequent light color and the most
...
...
packages/flutter_tools/gradle/flutter.gradle
View file @
7a88eb97
...
@@ -214,7 +214,7 @@ class FlutterPlugin implements Plugin<Project> {
...
@@ -214,7 +214,7 @@ class FlutterPlugin implements Plugin<Project> {
project
.
android
.
buildTypes
.
all
this
.&
addFlutterDependencies
project
.
android
.
buildTypes
.
all
this
.&
addFlutterDependencies
}
}
private
static
Boolean
shouldShrinkResources
(
Project
project
)
{
private
static
Boolean
shouldShrinkResources
(
Project
project
)
{
if
(
project
.
hasProperty
(
"shrink"
))
{
if
(
project
.
hasProperty
(
"shrink"
))
{
return
project
.
property
(
"shrink"
).
toBoolean
()
return
project
.
property
(
"shrink"
).
toBoolean
()
}
}
...
@@ -595,7 +595,7 @@ class FlutterPlugin implements Plugin<Project> {
...
@@ -595,7 +595,7 @@ class FlutterPlugin implements Plugin<Project> {
/**
/**
* Gets the directory that contains the Flutter source code.
* Gets the directory that contains the Flutter source code.
* This is the
the
directory containing the `android/` directory.
* This is the directory containing the `android/` directory.
*/
*/
private
File
getFlutterSourceDirectory
()
{
private
File
getFlutterSourceDirectory
()
{
if
(
project
.
flutter
.
source
==
null
)
{
if
(
project
.
flutter
.
source
==
null
)
{
...
@@ -842,7 +842,7 @@ class FlutterPlugin implements Plugin<Project> {
...
@@ -842,7 +842,7 @@ class FlutterPlugin implements Plugin<Project> {
}
}
return
copyFlutterAssetsTask
return
copyFlutterAssetsTask
}
// end def addFlutterDeps
}
// end def addFlutterDeps
if
(
isFlutterAppProject
())
{
if
(
isFlutterAppProject
())
{
project
.
android
.
applicationVariants
.
all
{
variant
->
project
.
android
.
applicationVariants
.
all
{
variant
->
Task
assembleTask
=
getAssembleTask
(
variant
)
Task
assembleTask
=
getAssembleTask
(
variant
)
...
...
packages/flutter_tools/lib/src/persistent_tool_state.dart
View file @
7a88eb97
...
@@ -55,7 +55,7 @@ abstract class PersistentToolState {
...
@@ -55,7 +55,7 @@ abstract class PersistentToolState {
/// Whether this client was already determined to be or not be a bot.
/// Whether this client was already determined to be or not be a bot.
bool
isRunningOnBot
;
bool
isRunningOnBot
;
/// The last time the
the
DevTools package was activated from pub.
/// The last time the DevTools package was activated from pub.
DateTime
lastDevToolsActivationTime
;
DateTime
lastDevToolsActivationTime
;
}
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment