Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
76c7ca54
Unverified
Commit
76c7ca54
authored
Jul 28, 2020
by
Darren Austin
Committed by
GitHub
Jul 28, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Updated the About dialog to use the new button API. (#62075)
parent
9bf1793a
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
13 additions
and
13 deletions
+13
-13
about.dart
packages/flutter/lib/src/material/about.dart
+4
-4
about_test.dart
packages/flutter/test/material/about_test.dart
+9
-9
No files found.
packages/flutter/lib/src/material/about.dart
View file @
76c7ca54
...
...
@@ -19,7 +19,6 @@ import 'card.dart';
import
'constants.dart'
;
import
'debug.dart'
;
import
'dialog.dart'
;
import
'flat_button.dart'
;
import
'floating_action_button.dart'
;
import
'floating_action_button_location.dart'
;
import
'ink_decoration.dart'
;
...
...
@@ -31,6 +30,7 @@ import 'page_transitions_theme.dart';
import
'progress_indicator.dart'
;
import
'scaffold.dart'
;
import
'scrollbar.dart'
;
import
'text_button.dart'
;
import
'text_theme.dart'
;
import
'theme.dart'
;
...
...
@@ -97,7 +97,7 @@ import 'theme.dart';
/// ),
/// ),
/// body: Center(
/// child:
Rais
edButton(
/// child:
Elevat
edButton(
/// child: Text('Show About Example'),
/// onPressed: () {
/// showAboutDialog(
...
...
@@ -406,7 +406,7 @@ class AboutDialog extends StatelessWidget {
],
),
actions:
<
Widget
>[
Fla
tButton
(
Tex
tButton
(
child:
Text
(
MaterialLocalizations
.
of
(
context
).
viewLicensesButtonLabel
),
onPressed:
()
{
showLicensePage
(
...
...
@@ -418,7 +418,7 @@ class AboutDialog extends StatelessWidget {
);
},
),
Fla
tButton
(
Tex
tButton
(
child:
Text
(
MaterialLocalizations
.
of
(
context
).
closeButtonLabel
),
onPressed:
()
{
Navigator
.
pop
(
context
);
...
...
packages/flutter/test/material/about_test.dart
View file @
76c7ca54
...
...
@@ -358,7 +358,7 @@ void main() {
onGenerateRoute:
(
RouteSettings
settings
)
{
return
PageRouteBuilder
<
dynamic
>(
pageBuilder:
(
BuildContext
context
,
_
,
__
)
{
return
Rais
edButton
(
return
Elevat
edButton
(
onPressed:
()
{
showLicensePage
(
context:
context
,
...
...
@@ -376,7 +376,7 @@ void main() {
));
// Open the dialog.
await
tester
.
tap
(
find
.
byType
(
Rais
edButton
));
await
tester
.
tap
(
find
.
byType
(
Elevat
edButton
));
expect
(
rootObserver
.
licensePageCount
,
0
);
expect
(
nestedObserver
.
licensePageCount
,
1
);
...
...
@@ -396,7 +396,7 @@ void main() {
onGenerateRoute:
(
RouteSettings
settings
)
{
return
PageRouteBuilder
<
dynamic
>(
pageBuilder:
(
BuildContext
context
,
_
,
__
)
{
return
Rais
edButton
(
return
Elevat
edButton
(
onPressed:
()
{
showLicensePage
(
context:
context
,
...
...
@@ -415,7 +415,7 @@ void main() {
));
// Open the dialog.
await
tester
.
tap
(
find
.
byType
(
Rais
edButton
));
await
tester
.
tap
(
find
.
byType
(
Elevat
edButton
));
expect
(
rootObserver
.
licensePageCount
,
1
);
expect
(
nestedObserver
.
licensePageCount
,
0
);
...
...
@@ -432,7 +432,7 @@ void main() {
onGenerateRoute:
(
RouteSettings
settings
)
{
return
MaterialPageRoute
<
dynamic
>(
builder:
(
BuildContext
context
)
{
return
Rais
edButton
(
return
Elevat
edButton
(
onPressed:
()
{
showAboutDialog
(
context:
context
,
...
...
@@ -448,7 +448,7 @@ void main() {
));
// Open the dialog.
await
tester
.
tap
(
find
.
byType
(
Rais
edButton
));
await
tester
.
tap
(
find
.
byType
(
Elevat
edButton
));
expect
(
rootObserver
.
dialogCount
,
1
);
expect
(
nestedObserver
.
dialogCount
,
0
);
...
...
@@ -465,7 +465,7 @@ void main() {
onGenerateRoute:
(
RouteSettings
settings
)
{
return
MaterialPageRoute
<
dynamic
>(
builder:
(
BuildContext
context
)
{
return
Rais
edButton
(
return
Elevat
edButton
(
onPressed:
()
{
showAboutDialog
(
context:
context
,
...
...
@@ -482,7 +482,7 @@ void main() {
));
// Open the dialog.
await
tester
.
tap
(
find
.
byType
(
Rais
edButton
));
await
tester
.
tap
(
find
.
byType
(
Elevat
edButton
));
expect
(
rootObserver
.
dialogCount
,
0
);
expect
(
nestedObserver
.
dialogCount
,
1
);
...
...
@@ -515,7 +515,7 @@ void main() {
onGenerateRoute:
(
RouteSettings
settings
)
{
return
MaterialPageRoute
<
dynamic
>(
builder:
(
BuildContext
context
)
{
return
Rais
edButton
(
return
Elevat
edButton
(
onPressed:
()
{
showAboutDialog
(
context:
context
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment