Unverified Commit 76be5581 authored by LongCatIsLooong's avatar LongCatIsLooong Committed by GitHub

Move caret/highlight painting to custom painters (#72828)

parent 09adc359
...@@ -2640,7 +2640,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien ...@@ -2640,7 +2640,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
cursorWidth: widget.cursorWidth, cursorWidth: widget.cursorWidth,
cursorHeight: widget.cursorHeight, cursorHeight: widget.cursorHeight,
cursorRadius: widget.cursorRadius, cursorRadius: widget.cursorRadius,
cursorOffset: widget.cursorOffset, cursorOffset: widget.cursorOffset ?? Offset.zero,
selectionHeightStyle: widget.selectionHeightStyle, selectionHeightStyle: widget.selectionHeightStyle,
selectionWidthStyle: widget.selectionWidthStyle, selectionWidthStyle: widget.selectionWidthStyle,
paintCursorAboveText: widget.paintCursorAboveText, paintCursorAboveText: widget.paintCursorAboveText,
...@@ -2724,7 +2724,7 @@ class _Editable extends LeafRenderObjectWidget { ...@@ -2724,7 +2724,7 @@ class _Editable extends LeafRenderObjectWidget {
required this.cursorWidth, required this.cursorWidth,
this.cursorHeight, this.cursorHeight,
this.cursorRadius, this.cursorRadius,
this.cursorOffset, required this.cursorOffset,
required this.paintCursorAboveText, required this.paintCursorAboveText,
this.selectionHeightStyle = ui.BoxHeightStyle.tight, this.selectionHeightStyle = ui.BoxHeightStyle.tight,
this.selectionWidthStyle = ui.BoxWidthStyle.tight, this.selectionWidthStyle = ui.BoxWidthStyle.tight,
...@@ -2772,7 +2772,7 @@ class _Editable extends LeafRenderObjectWidget { ...@@ -2772,7 +2772,7 @@ class _Editable extends LeafRenderObjectWidget {
final double cursorWidth; final double cursorWidth;
final double? cursorHeight; final double? cursorHeight;
final Radius? cursorRadius; final Radius? cursorRadius;
final Offset? cursorOffset; final Offset cursorOffset;
final bool paintCursorAboveText; final bool paintCursorAboveText;
final ui.BoxHeightStyle selectionHeightStyle; final ui.BoxHeightStyle selectionHeightStyle;
final ui.BoxWidthStyle selectionWidthStyle; final ui.BoxWidthStyle selectionWidthStyle;
......
...@@ -5792,7 +5792,7 @@ void main() { ...@@ -5792,7 +5792,7 @@ void main() {
await tester.pump(); await tester.pump();
// Nothing called when only the remote changes. // Nothing called when only the remote changes.
expect(log.length, 0); expect(log, isEmpty);
controller.clear(); controller.clear();
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment