Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
76be5581
Unverified
Commit
76be5581
authored
Feb 01, 2021
by
LongCatIsLooong
Committed by
GitHub
Feb 01, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move caret/highlight painting to custom painters (#72828)
parent
09adc359
Changes
4
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
964 additions
and
336 deletions
+964
-336
editable.dart
packages/flutter/lib/src/rendering/editable.dart
+678
-313
editable_text.dart
packages/flutter/lib/src/widgets/editable_text.dart
+3
-3
editable_test.dart
packages/flutter/test/rendering/editable_test.dart
+282
-19
editable_text_test.dart
packages/flutter/test/widgets/editable_text_test.dart
+1
-1
No files found.
packages/flutter/lib/src/rendering/editable.dart
View file @
76be5581
This diff is collapsed.
Click to expand it.
packages/flutter/lib/src/widgets/editable_text.dart
View file @
76be5581
...
...
@@ -2640,7 +2640,7 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
cursorWidth:
widget
.
cursorWidth
,
cursorHeight:
widget
.
cursorHeight
,
cursorRadius:
widget
.
cursorRadius
,
cursorOffset:
widget
.
cursorOffset
,
cursorOffset:
widget
.
cursorOffset
??
Offset
.
zero
,
selectionHeightStyle:
widget
.
selectionHeightStyle
,
selectionWidthStyle:
widget
.
selectionWidthStyle
,
paintCursorAboveText:
widget
.
paintCursorAboveText
,
...
...
@@ -2724,7 +2724,7 @@ class _Editable extends LeafRenderObjectWidget {
required
this
.
cursorWidth
,
this
.
cursorHeight
,
this
.
cursorRadius
,
this
.
cursorOffset
,
required
this
.
cursorOffset
,
required
this
.
paintCursorAboveText
,
this
.
selectionHeightStyle
=
ui
.
BoxHeightStyle
.
tight
,
this
.
selectionWidthStyle
=
ui
.
BoxWidthStyle
.
tight
,
...
...
@@ -2772,7 +2772,7 @@ class _Editable extends LeafRenderObjectWidget {
final
double
cursorWidth
;
final
double
?
cursorHeight
;
final
Radius
?
cursorRadius
;
final
Offset
?
cursorOffset
;
final
Offset
cursorOffset
;
final
bool
paintCursorAboveText
;
final
ui
.
BoxHeightStyle
selectionHeightStyle
;
final
ui
.
BoxWidthStyle
selectionWidthStyle
;
...
...
packages/flutter/test/rendering/editable_test.dart
View file @
76be5581
This diff is collapsed.
Click to expand it.
packages/flutter/test/widgets/editable_text_test.dart
View file @
76be5581
...
...
@@ -5792,7 +5792,7 @@ void main() {
await
tester
.
pump
();
// Nothing called when only the remote changes.
expect
(
log
.
length
,
0
);
expect
(
log
,
isEmpty
);
controller
.
clear
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment