Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
74a1b9b3
Unverified
Commit
74a1b9b3
authored
Apr 09, 2020
by
Jonah Williams
Committed by
GitHub
Apr 09, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] make verbose macOS builds actually verbose (#54320)
parent
4451ffca
Changes
4
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
27 additions
and
1 deletion
+27
-1
build_macos.dart
packages/flutter_tools/lib/src/commands/build_macos.dart
+1
-0
build_macos.dart
packages/flutter_tools/lib/src/macos/build_macos.dart
+5
-0
macos_device.dart
packages/flutter_tools/lib/src/macos/macos_device.dart
+1
-0
build_macos_test.dart
..._tools/test/commands.shard/hermetic/build_macos_test.dart
+20
-1
No files found.
packages/flutter_tools/lib/src/commands/build_macos.dart
View file @
74a1b9b3
...
...
@@ -54,6 +54,7 @@ class BuildMacosCommand extends BuildSubCommand {
flutterProject:
flutterProject
,
buildInfo:
buildInfo
,
targetOverride:
targetFile
,
verboseLogging:
globals
.
logger
.
isVerbose
,
);
return
FlutterCommandResult
.
success
();
}
...
...
packages/flutter_tools/lib/src/macos/build_macos.dart
View file @
74a1b9b3
...
...
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import
'package:meta/meta.dart'
;
import
'../base/common.dart'
;
import
'../base/file_system.dart'
;
import
'../base/logger.dart'
;
...
...
@@ -18,6 +20,7 @@ Future<void> buildMacOS({
FlutterProject
flutterProject
,
BuildInfo
buildInfo
,
String
targetOverride
,
@required
bool
verboseLogging
,
})
async
{
if
(!
flutterProject
.
macos
.
xcodeWorkspace
.
existsSync
())
{
throwToolExit
(
'No macOS desktop project configured. '
...
...
@@ -83,6 +86,8 @@ Future<void> buildMacOS({
'-derivedDataPath'
,
flutterBuildDir
.
absolute
.
path
,
'OBJROOT=
${globals.fs.path.join(flutterBuildDir.absolute.path, 'Build', 'Intermediates.noindex')}
'
,
'SYMROOT=
${globals.fs.path.join(flutterBuildDir.absolute.path, 'Build', 'Products')}
'
,
if
(
verboseLogging
)
'VERBOSE_SCRIPT_LOGGING=YES'
,
'COMPILER_INDEX_STORE_ENABLE=NO'
,
...
environmentVariablesAsXcodeBuildSettings
(
globals
.
platform
)
],
trace:
true
);
...
...
packages/flutter_tools/lib/src/macos/macos_device.dart
View file @
74a1b9b3
...
...
@@ -44,6 +44,7 @@ class MacOSDevice extends DesktopDevice {
flutterProject:
FlutterProject
.
current
(),
buildInfo:
buildInfo
,
targetOverride:
mainPath
,
verboseLogging:
globals
.
logger
.
isVerbose
,
);
}
...
...
packages/flutter_tools/test/commands.shard/hermetic/build_macos_test.dart
View file @
74a1b9b3
...
...
@@ -69,7 +69,7 @@ void main() {
// Creates a FakeCommand for the xcodebuild call to build the app
// in the given configuration.
FakeCommand
setUpMockXcodeBuildHandler
(
String
configuration
)
{
FakeCommand
setUpMockXcodeBuildHandler
(
String
configuration
,
{
bool
verbose
=
false
}
)
{
final
FlutterProject
flutterProject
=
FlutterProject
.
fromDirectory
(
fileSystem
.
currentDirectory
);
final
Directory
flutterBuildDir
=
fileSystem
.
directory
(
getMacOSBuildDirectory
());
return
FakeCommand
(
...
...
@@ -83,6 +83,8 @@ void main() {
'-derivedDataPath'
,
flutterBuildDir
.
absolute
.
path
,
'OBJROOT=
${fileSystem.path.join(flutterBuildDir.absolute.path, 'Build', 'Intermediates.noindex')}
'
,
'SYMROOT=
${fileSystem.path.join(flutterBuildDir.absolute.path, 'Build', 'Products')}
'
,
if
(
verbose
)
'VERBOSE_SCRIPT_LOGGING=YES'
,
'COMPILER_INDEX_STORE_ENABLE=NO'
,
],
stdout:
'STDOUT STUFF'
,
...
...
@@ -159,6 +161,23 @@ void main() {
FeatureFlags:
()
=>
TestFeatureFlags
(
isMacOSEnabled:
true
),
});
testUsingContext
(
'macOS build invokes xcode build (debug) with verbosity'
,
()
async
{
final
BuildCommand
command
=
BuildCommand
();
createMinimalMockProjectFiles
();
await
createTestCommandRunner
(
command
).
run
(
const
<
String
>[
'build'
,
'macos'
,
'--debug'
,
'-v'
]
);
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fileSystem
,
ProcessManager:
()
=>
FakeProcessManager
.
list
(<
FakeCommand
>[
setUpMockXcodeBuildHandler
(
'Debug'
,
verbose:
true
)
]),
Platform:
()
=>
macosPlatform
,
FeatureFlags:
()
=>
TestFeatureFlags
(
isMacOSEnabled:
true
),
});
testUsingContext
(
'macOS build invokes xcode build (profile)'
,
()
async
{
final
BuildCommand
command
=
BuildCommand
();
createMinimalMockProjectFiles
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment