Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
70f6bed9
Unverified
Commit
70f6bed9
authored
Sep 08, 2022
by
Camille Simon
Committed by
GitHub
Sep 08, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix spell_check_test (#110814)
parent
652ff7a5
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
6 additions
and
7 deletions
+6
-7
launch_background.xml
...e/android/app/src/main/res/drawable/launch_background.xml
+1
-1
styles.xml
...ts/spell_check/android/app/src/main/res/values/styles.xml
+1
-1
integration_test.dart
..._tests/spell_check/integration_test/integration_test.dart
+2
-2
spell_check.dart
packages/flutter/lib/src/services/spell_check.dart
+1
-2
launch_background.xml
...e/android/app/src/main/res/drawable/launch_background.xml
+1
-1
No files found.
dev/integration_tests/non_nullable/android/app/src/main/res/drawable/launch_background.xml
View file @
70f6bed9
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2014 The Flutter Authors. All rights reserved.
<!-- Copyright 2014 The Flutter Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
found in the LICENSE file. -->
<?xml version="1.0" encoding="utf-8"?>
<!-- Modify this file to customize your launch splash screen -->
<!-- Modify this file to customize your launch splash screen -->
<layer-list
xmlns:android=
"http://schemas.android.com/apk/res/android"
>
<layer-list
xmlns:android=
"http://schemas.android.com/apk/res/android"
>
<item
android:drawable=
"@android:color/white"
/>
<item
android:drawable=
"@android:color/white"
/>
...
...
dev/integration_tests/spell_check/android/app/src/main/res/values/styles.xml
View file @
70f6bed9
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2014 The Flutter Authors. All rights reserved.
<!-- Copyright 2014 The Flutter Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
found in the LICENSE file. -->
<?xml version="1.0" encoding="utf-8"?>
<resources>
<resources>
<!-- Theme applied to the Android Window while the process is starting when the OS's Dark Mode setting is off -->
<!-- Theme applied to the Android Window while the process is starting when the OS's Dark Mode setting is off -->
<style
name=
"LaunchTheme"
parent=
"@android:style/Theme.Light.NoTitleBar"
>
<style
name=
"LaunchTheme"
parent=
"@android:style/Theme.Light.NoTitleBar"
>
...
...
dev/integration_tests/spell_check/integration_test/integration_test.dart
View file @
70f6bed9
...
@@ -147,7 +147,7 @@ Future<void> main() async {
...
@@ -147,7 +147,7 @@ Future<void> main() async {
await
tester
.
pumpWidget
(
const
MyApp
());
await
tester
.
pumpWidget
(
const
MyApp
());
await
tester
.
enterText
(
find
.
byType
(
EditableText
),
'Hey
wrororld
! Hey!'
);
await
tester
.
enterText
(
find
.
byType
(
EditableText
),
'Hey
cfabiueqqocnakoef
! Hey!'
);
await
tester
.
pumpAndSettle
();
await
tester
.
pumpAndSettle
();
final
RenderEditable
renderEditable
=
findRenderEditable
(
tester
,
EditableText
);
final
RenderEditable
renderEditable
=
findRenderEditable
(
tester
,
EditableText
);
...
@@ -157,7 +157,7 @@ Future<void> main() async {
...
@@ -157,7 +157,7 @@ Future<void> main() async {
style:
style
,
style:
style
,
children:
<
TextSpan
>[
children:
<
TextSpan
>[
TextSpan
(
style:
style
,
text:
'Hey '
),
TextSpan
(
style:
style
,
text:
'Hey '
),
TextSpan
(
style:
misspelledTextStyle
,
text:
'
wrororld
'
),
TextSpan
(
style:
misspelledTextStyle
,
text:
'
cfabiueqqocnakoef
'
),
TextSpan
(
style:
style
,
text:
'! Hey!'
),
TextSpan
(
style:
style
,
text:
'! Hey!'
),
]);
]);
...
...
packages/flutter/lib/src/services/spell_check.dart
View file @
70f6bed9
...
@@ -211,9 +211,8 @@ class DefaultSpellCheckService implements SpellCheckService {
...
@@ -211,9 +211,8 @@ class DefaultSpellCheckService implements SpellCheckService {
if
(
textHasNotChanged
&&
spansHaveChanged
)
{
if
(
textHasNotChanged
&&
spansHaveChanged
)
{
suggestionSpans
=
mergeResults
(
lastSavedResults
!.
suggestionSpans
,
suggestionSpans
);
suggestionSpans
=
mergeResults
(
lastSavedResults
!.
suggestionSpans
,
suggestionSpans
);
}
}
lastSavedResults
=
SpellCheckResults
(
text
,
suggestionSpans
);
}
}
lastSavedResults
=
SpellCheckResults
(
text
,
suggestionSpans
);
return
suggestionSpans
;
return
suggestionSpans
;
}
}
...
...
packages/integration_test/example/android/app/src/main/res/drawable/launch_background.xml
View file @
70f6bed9
<?xml version="1.0" encoding="utf-8"?>
<!-- Copyright 2014 The Flutter Authors. All rights reserved.
<!-- Copyright 2014 The Flutter Authors. All rights reserved.
Use of this source code is governed by a BSD-style license that can be
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
found in the LICENSE file. -->
<?xml version="1.0" encoding="utf-8"?>
<!-- Modify this file to customize your launch splash screen -->
<!-- Modify this file to customize your launch splash screen -->
<layer-list
xmlns:android=
"http://schemas.android.com/apk/res/android"
>
<layer-list
xmlns:android=
"http://schemas.android.com/apk/res/android"
>
<item
android:drawable=
"@android:color/white"
/>
<item
android:drawable=
"@android:color/white"
/>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment