Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
707f995d
Unverified
Commit
707f995d
authored
Aug 25, 2020
by
Mouad Debbar
Committed by
GitHub
Aug 25, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[web] Fix and enable editable_text_test.dart (#64516)
parent
be7c7fae
Changes
3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
93 additions
and
46 deletions
+93
-46
test.dart
dev/bots/test.dart
+0
-1
editable_text.dart
packages/flutter/lib/src/widgets/editable_text.dart
+5
-0
editable_text_test.dart
packages/flutter/test/widgets/editable_text_test.dart
+88
-45
No files found.
dev/bots/test.dart
View file @
707f995d
...
...
@@ -92,7 +92,6 @@ const List<String> kWebTestFileKnownFailures = <String>[
'test/widgets/selectable_text_test.dart'
,
'test/widgets/color_filter_test.dart'
,
'test/widgets/editable_text_cursor_test.dart'
,
'test/widgets/editable_text_test.dart'
,
'test/material/animated_icons_private_test.dart'
,
'test/material/data_table_test.dart'
,
'test/cupertino/nav_bar_transition_test.dart'
,
...
...
packages/flutter/lib/src/widgets/editable_text.dart
View file @
707f995d
...
...
@@ -1627,6 +1627,11 @@ class EditableTextState extends State<EditableText> with AutomaticKeepAliveClien
if
(!
_shouldCreateInputConnection
)
{
return
;
}
if
(
widget
.
readOnly
)
{
// In the read-only case, we only care about selection changes, and reject
// everything else.
value
=
_value
.
copyWith
(
selection:
value
.
selection
);
}
_receivedRemoteTextEditingValue
=
value
;
if
(
value
.
text
!=
_value
.
text
)
{
hideToolbar
();
...
...
packages/flutter/test/widgets/editable_text_test.dart
View file @
707f995d
This diff is collapsed.
Click to expand it.
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment