Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
6f26e806
Unverified
Commit
6f26e806
authored
Aug 14, 2020
by
Ming Lyu (CareF)
Committed by
GitHub
Aug 14, 2020
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
bug fix for flutter_gallery__transition_perf(_with_semantics) (#63799)
* report failure for semantics test * bug fix
parent
ede1b15b
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
14 additions
and
2 deletions
+14
-2
flutter_gallery__transition_perf_with_semantics.dart
...asks/flutter_gallery__transition_perf_with_semantics.dart
+12
-0
gallery.dart
dev/devicelab/lib/tasks/gallery.dart
+2
-2
No files found.
dev/devicelab/bin/tasks/flutter_gallery__transition_perf_with_semantics.dart
View file @
6f26e806
...
...
@@ -13,6 +13,18 @@ Future<void> main() async {
await
task
(()
async
{
final
TaskResult
withoutSemantics
=
await
createGalleryTransitionTest
()();
final
TaskResult
withSemantics
=
await
createGalleryTransitionTest
(
semanticsEnabled:
true
)();
if
(
withSemantics
.
benchmarkScoreKeys
.
isEmpty
||
withoutSemantics
.
benchmarkScoreKeys
.
isEmpty
)
{
String
message
=
'Lack of data'
;
if
(
withSemantics
.
benchmarkScoreKeys
.
isEmpty
)
{
message
+=
' for test with semantics'
;
if
(
withoutSemantics
.
benchmarkScoreKeys
.
isEmpty
)
{
message
+=
' and without semantics'
;
}
}
else
{
message
+=
'for test without semantics'
;
}
return
TaskResult
.
failure
(
message
);
}
final
List
<
String
>
benchmarkScoreKeys
=
<
String
>[];
final
Map
<
String
,
dynamic
>
data
=
<
String
,
dynamic
>{};
...
...
dev/devicelab/lib/tasks/gallery.dart
View file @
6f26e806
...
...
@@ -64,8 +64,8 @@ class GalleryTransitionTest {
await
flutter
(
'packages'
,
options:
<
String
>[
'get'
]);
final
String
testDriver
=
driverFile
??
(
semanticsEnabled
?
'
${testFile}
_test'
:
'
${testFile}
_
with_semantics_
test'
);
?
'
${testFile}
_
with_semantics_
test'
:
'
${testFile}
_test'
);
await
flutter
(
'drive'
,
options:
<
String
>[
'--profile'
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment