Unverified Commit 6f26e806 authored by Ming Lyu (CareF)'s avatar Ming Lyu (CareF) Committed by GitHub

bug fix for flutter_gallery__transition_perf(_with_semantics) (#63799)

* report failure for semantics test

* bug fix
parent ede1b15b
......@@ -13,6 +13,18 @@ Future<void> main() async {
await task(() async {
final TaskResult withoutSemantics = await createGalleryTransitionTest()();
final TaskResult withSemantics = await createGalleryTransitionTest(semanticsEnabled: true)();
if (withSemantics.benchmarkScoreKeys.isEmpty || withoutSemantics.benchmarkScoreKeys.isEmpty) {
String message = 'Lack of data';
if (withSemantics.benchmarkScoreKeys.isEmpty) {
message += ' for test with semantics';
if (withoutSemantics.benchmarkScoreKeys.isEmpty) {
message += ' and without semantics';
}
} else {
message += 'for test without semantics';
}
return TaskResult.failure(message);
}
final List<String> benchmarkScoreKeys = <String>[];
final Map<String, dynamic> data = <String, dynamic>{};
......
......@@ -64,8 +64,8 @@ class GalleryTransitionTest {
await flutter('packages', options: <String>['get']);
final String testDriver = driverFile ?? (semanticsEnabled
? '${testFile}_test'
: '${testFile}_with_semantics_test');
? '${testFile}_with_semantics_test'
: '${testFile}_test');
await flutter('drive', options: <String>[
'--profile',
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment