Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
698bda6a
Unverified
Commit
698bda6a
authored
Jul 13, 2018
by
Hans Muller
Committed by
GitHub
Jul 13, 2018
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Correct contentPadding type in InputDecoration.debugFillProperties (#19318)
parent
35f37403
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
17 additions
and
6 deletions
+17
-6
input_decorator.dart
packages/flutter/lib/src/material/input_decorator.dart
+1
-1
input_decorator_test.dart
packages/flutter/test/material/input_decorator_test.dart
+16
-5
No files found.
packages/flutter/lib/src/material/input_decorator.dart
View file @
698bda6a
...
...
@@ -2507,7 +2507,7 @@ class InputDecorationTheme extends Diagnosticable {
properties
.
add
(
new
DiagnosticsProperty
<
TextStyle
>(
'errorStyle'
,
errorStyle
,
defaultValue:
defaultTheme
.
errorStyle
));
properties
.
add
(
new
DiagnosticsProperty
<
int
>(
'errorMaxLines'
,
errorMaxLines
,
defaultValue:
defaultTheme
.
errorMaxLines
));
properties
.
add
(
new
DiagnosticsProperty
<
bool
>(
'isDense'
,
isDense
,
defaultValue:
defaultTheme
.
isDense
));
properties
.
add
(
new
DiagnosticsProperty
<
EdgeInsets
>(
'contentPadding'
,
contentPadding
,
defaultValue:
defaultTheme
.
contentPadding
));
properties
.
add
(
new
DiagnosticsProperty
<
EdgeInsets
Directional
>(
'contentPadding'
,
contentPadding
,
defaultValue:
defaultTheme
.
contentPadding
));
properties
.
add
(
new
DiagnosticsProperty
<
bool
>(
'isCollapsed'
,
isCollapsed
,
defaultValue:
defaultTheme
.
isCollapsed
));
properties
.
add
(
new
DiagnosticsProperty
<
TextStyle
>(
'prefixStyle'
,
prefixStyle
,
defaultValue:
defaultTheme
.
prefixStyle
));
properties
.
add
(
new
DiagnosticsProperty
<
TextStyle
>(
'suffixStyle'
,
suffixStyle
,
defaultValue:
defaultTheme
.
suffixStyle
));
...
...
packages/flutter/test/material/input_decorator_test.dart
View file @
698bda6a
...
...
@@ -763,7 +763,7 @@ void main() {
),
);
// Overall height for this InputDecorator is 48dps because the prefix icon's minimum size
// Overall height for this InputDecorator is 48dps because the prefix icon's minimum size
// is 48x48 and the rest of the elements only require 40dps:
// 12 - top padding
// 16 - input text (ahem font size 16dps)
...
...
@@ -799,7 +799,7 @@ void main() {
),
);
// Overall height for this InputDecorator is 48dps because the prefix icon's minimum size
// Overall height for this InputDecorator is 48dps because the prefix icon's minimum size
// is 48x48 and the rest of the elements only require 40dps:
// 12 - top padding
// 16 - input text (ahem font size 16dps)
...
...
@@ -821,7 +821,7 @@ void main() {
),
);
// Overall height for this InputDecorator is 100dps because the prefix icon's size
// Overall height for this InputDecorator is 100dps because the prefix icon's size
// is 100x100 and the rest of the elements only require 40dps:
// 12 - top padding
// 16 - input text (ahem font size 16dps)
...
...
@@ -864,7 +864,7 @@ void main() {
),
),
);
// Margin for text decoration is 12 when filled and top left offset is (0, 0)
// 0 + 12 = 12.
expect
(
tester
.
getSize
(
find
.
byType
(
InputDecorator
)),
const
Size
(
800.0
,
60.0
));
...
...
@@ -904,7 +904,7 @@ void main() {
),
),
);
// Margin for text decoration is 12 when filled and top left offset is (0, 0)
// 0 + 12 = 12.
expect
(
tester
.
getSize
(
find
.
byType
(
InputDecorator
)),
const
Size
(
800.0
,
52.0
));
...
...
@@ -1639,4 +1639,15 @@ void main() {
},
skip:
!
Platform
.
isLinux
,
);
testWidgets
(
'InputDecorationTheme.toString()'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/19305
expect
(
const
InputDecorationTheme
(
contentPadding:
const
EdgeInsetsDirectional
.
only
(
start:
5.0
),
).
toString
(),
contains
(
'contentPadding: EdgeInsetsDirectional(5.0, 0.0, 0.0, 0.0)'
),
);
});
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment