Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
67a57eb9
Unverified
Commit
67a57eb9
authored
Jun 10, 2021
by
Jonah Williams
Committed by
GitHub
Jun 10, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] remove feature for alternative invalidation strategy (#84366)
parent
01e823c4
Changes
5
Hide whitespace changes
Inline
Side-by-side
Showing
5 changed files
with
2 additions
and
40 deletions
+2
-40
features.dart
packages/flutter_tools/lib/src/features.dart
+0
-27
flutter_features.dart
packages/flutter_tools/lib/src/flutter_features.dart
+0
-3
resident_runner.dart
packages/flutter_tools/lib/src/resident_runner.dart
+1
-2
resident_runner_test.dart
...lutter_tools/test/general.shard/resident_runner_test.dart
+1
-2
fakes.dart
packages/flutter_tools/test/src/fakes.dart
+0
-6
No files found.
packages/flutter_tools/lib/src/features.dart
View file @
67a57eb9
...
...
@@ -47,9 +47,6 @@ abstract class FeatureFlags {
/// Whether fast single widget reloads are enabled.
bool
get
isSingleWidgetReloadEnabled
=>
false
;
/// Whether the CFE experimental invalidation strategy is enabled.
bool
get
isExperimentalInvalidationStrategyEnabled
=>
true
;
/// Whether the windows UWP embedding is enabled.
bool
get
isWindowsUwpEnabled
=>
false
;
...
...
@@ -71,7 +68,6 @@ const List<Feature> allFeatures = <Feature>[
flutterIOSFeature
,
flutterFuchsiaFeature
,
flutterCustomDevicesFeature
,
experimentalInvalidationStrategy
,
];
/// The [Feature] for flutter web.
...
...
@@ -270,29 +266,6 @@ const Feature singleWidgetReload = Feature(
),
);
/// The CFE experimental invalidation strategy.
const
Feature
experimentalInvalidationStrategy
=
Feature
(
name:
'Hot reload optimization that reduces incremental artifact size'
,
configSetting:
'experimental-invalidation-strategy'
,
environmentOverride:
'FLUTTER_CFE_EXPERIMENTAL_INVALIDATION'
,
master:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
dev:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
beta:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
stable:
FeatureChannelSetting
(
available:
true
,
enabledByDefault:
true
,
),
);
/// The feature for enabling the Windows UWP embedding.
const
Feature
windowsUwpEmbedding
=
Feature
(
name:
'Flutter for Windows UWP'
,
...
...
packages/flutter_tools/lib/src/flutter_features.dart
View file @
67a57eb9
...
...
@@ -47,9 +47,6 @@ class FlutterFeatureFlags implements FeatureFlags {
@override
bool
get
isSingleWidgetReloadEnabled
=>
isEnabled
(
singleWidgetReload
);
@override
bool
get
isExperimentalInvalidationStrategyEnabled
=>
isEnabled
(
experimentalInvalidationStrategy
);
@override
bool
get
isWindowsUwpEnabled
=>
isEnabled
(
windowsUwpEmbedding
);
...
...
packages/flutter_tools/lib/src/resident_runner.dart
View file @
67a57eb9
...
...
@@ -151,8 +151,7 @@ class FlutterDevice {
extraFrontEndOptions
=
<
String
>[
if
(
featureFlags
.
isSingleWidgetReloadEnabled
)
'--flutter-widget-cache'
,
if
(
featureFlags
.
isExperimentalInvalidationStrategyEnabled
)
'--enable-experiment=alternative-invalidation-strategy'
,
'--enable-experiment=alternative-invalidation-strategy'
,
...?
extraFrontEndOptions
,
];
generator
=
ResidentCompiler
(
...
...
packages/flutter_tools/test/general.shard/resident_runner_test.dart
View file @
67a57eb9
...
...
@@ -2037,7 +2037,7 @@ void main() {
FeatureFlags:
()
=>
TestFeatureFlags
(
isSingleWidgetReloadEnabled:
true
)
});
testUsingContext
(
'FlutterDevice passes alternative-invalidation-strategy flag
when feature is enabled
'
,
()
async
{
testUsingContext
(
'FlutterDevice passes alternative-invalidation-strategy flag'
,
()
async
{
fakeVmServiceHost
=
FakeVmServiceHost
(
requests:
<
VmServiceExpectation
>[]);
final
FakeDevice
mockDevice
=
FakeDevice
(
targetPlatform:
TargetPlatform
.
android_arm
);
...
...
@@ -2059,7 +2059,6 @@ void main() {
Artifacts:
()
=>
Artifacts
.
test
(),
FileSystem:
()
=>
MemoryFileSystem
.
test
(),
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
FeatureFlags:
()
=>
TestFeatureFlags
(
isExperimentalInvalidationStrategyEnabled:
true
)
});
testUsingContext
(
'FlutterDevice passes initializeFromDill parameter if specified'
,
()
async
{
...
...
packages/flutter_tools/test/src/fakes.dart
View file @
67a57eb9
...
...
@@ -415,7 +415,6 @@ class TestFeatureFlags implements FeatureFlags {
this
.
isIOSEnabled
=
true
,
this
.
isFuchsiaEnabled
=
false
,
this
.
areCustomDevicesEnabled
=
false
,
this
.
isExperimentalInvalidationStrategyEnabled
=
false
,
this
.
isWindowsUwpEnabled
=
false
,
});
...
...
@@ -446,9 +445,6 @@ class TestFeatureFlags implements FeatureFlags {
@override
final
bool
areCustomDevicesEnabled
;
@override
final
bool
isExperimentalInvalidationStrategyEnabled
;
@override
final
bool
isWindowsUwpEnabled
;
...
...
@@ -473,8 +469,6 @@ class TestFeatureFlags implements FeatureFlags {
return
isFuchsiaEnabled
;
case
flutterCustomDevicesFeature:
return
areCustomDevicesEnabled
;
case
experimentalInvalidationStrategy:
return
isExperimentalInvalidationStrategyEnabled
;
case
windowsUwpEmbedding:
return
isWindowsUwpEnabled
;
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment