Commit 678af9c0 authored by Devon Carew's avatar Devon Carew

fix some issues found by strong mode

parent 9992a3e0
...@@ -12,8 +12,8 @@ import 'flutter_command.dart'; ...@@ -12,8 +12,8 @@ import 'flutter_command.dart';
final Logger _logging = new Logger('sky_tools.logs'); final Logger _logging = new Logger('sky_tools.logs');
class LogsCommand extends FlutterCommand { class LogsCommand extends FlutterCommand {
final name = 'logs'; final String name = 'logs';
final description = 'Show logs for running Sky apps.'; final String description = 'Show logs for running Sky apps.';
LogsCommand() { LogsCommand() {
argParser.addFlag('clear', argParser.addFlag('clear',
......
...@@ -810,13 +810,15 @@ class AndroidDevice extends Device { ...@@ -810,13 +810,15 @@ class AndroidDevice extends Device {
} }
@override @override
Future<bool> startApp(AndroidApk apk) async { Future<bool> startApp(ApplicationPackage app) async {
// Android currently has to be started with startServer(...). // Android currently has to be started with startServer(...).
assert(false); assert(false);
return false; return false;
} }
Future<bool> stopApp(AndroidApk apk) async { Future<bool> stopApp(ApplicationPackage app) async {
final AndroidApk apk = app;
// Turn off reverse port forwarding // Turn off reverse port forwarding
runSync([adbPath, 'reverse', '--remove', 'tcp:$_serverPort']); runSync([adbPath, 'reverse', '--remove', 'tcp:$_serverPort']);
// Stop the app // Stop the app
......
...@@ -69,7 +69,7 @@ class RemoteListener { ...@@ -69,7 +69,7 @@ class RemoteListener {
return; return;
} }
var declarer = new Declarer(); Declarer declarer = new Declarer();
try { try {
await runZoned(() => new Future.sync(main), zoneValues: { await runZoned(() => new Future.sync(main), zoneValues: {
#test.declarer: declarer #test.declarer: declarer
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment