Commit 6215abec authored by Andrew Wilson's avatar Andrew Wilson

Change generic value names to be more descriptive for assert tracing.

parent ea2ff273
...@@ -82,11 +82,11 @@ class RenderConstrainedBox extends RenderProxyBox { ...@@ -82,11 +82,11 @@ class RenderConstrainedBox extends RenderProxyBox {
BoxConstraints _additionalConstraints; BoxConstraints _additionalConstraints;
BoxConstraints get additionalConstraints => _additionalConstraints; BoxConstraints get additionalConstraints => _additionalConstraints;
void set additionalConstraints (BoxConstraints value) { void set additionalConstraints (BoxConstraints newConstraints) {
assert(value != null); assert(newConstraints != null);
if (_additionalConstraints == value) if (_additionalConstraints == newConstraints)
return; return;
_additionalConstraints = value; _additionalConstraints = newConstraints;
markNeedsLayout(); markNeedsLayout();
} }
...@@ -136,11 +136,11 @@ class RenderAspectRatio extends RenderProxyBox { ...@@ -136,11 +136,11 @@ class RenderAspectRatio extends RenderProxyBox {
double _aspectRatio; double _aspectRatio;
double get aspectRatio => _aspectRatio; double get aspectRatio => _aspectRatio;
void set aspectRatio (double value) { void set aspectRatio (double newAspectRatio) {
assert(value != null); assert(newAspectRatio != null);
if (_aspectRatio == value) if (_aspectRatio == newAspectRatio)
return; return;
_aspectRatio = value; _aspectRatio = newAspectRatio;
markNeedsLayout(); markNeedsLayout();
} }
...@@ -190,19 +190,19 @@ class RenderShrinkWrapWidth extends RenderProxyBox { ...@@ -190,19 +190,19 @@ class RenderShrinkWrapWidth extends RenderProxyBox {
double _stepWidth; double _stepWidth;
double get stepWidth => _stepWidth; double get stepWidth => _stepWidth;
void set stepWidth(double value) { void set stepWidth(double newStepWidth) {
if (value == _stepWidth) if (newStepWidth == _stepWidth)
return; return;
_stepWidth = value; _stepWidth = newStepWidth;
markNeedsLayout(); markNeedsLayout();
} }
double _stepHeight; double _stepHeight;
double get stepHeight => _stepHeight; double get stepHeight => _stepHeight;
void set stepHeight(double value) { void set stepHeight(double newStepHeight) {
if (value == _stepHeight) if (newStepHeight == _stepHeight)
return; return;
_stepHeight = value; _stepHeight = newStepHeight;
markNeedsLayout(); markNeedsLayout();
} }
...@@ -269,12 +269,12 @@ class RenderOpacity extends RenderProxyBox { ...@@ -269,12 +269,12 @@ class RenderOpacity extends RenderProxyBox {
double _opacity; double _opacity;
double get opacity => _opacity; double get opacity => _opacity;
void set opacity (double value) { void set opacity (double newOpacity) {
assert(value != null); assert(newOpacity != null);
assert(value >= 0.0 && value <= 1.0); assert(newOpacity >= 0.0 && newOpacity <= 1.0);
if (_opacity == value) if (_opacity == newOpacity)
return; return;
_opacity = value; _opacity = newOpacity;
markNeedsPaint(); markNeedsPaint();
} }
...@@ -300,21 +300,21 @@ class RenderColorFilter extends RenderProxyBox { ...@@ -300,21 +300,21 @@ class RenderColorFilter extends RenderProxyBox {
Color _color; Color _color;
Color get color => _color; Color get color => _color;
void set color (Color value) { void set color (Color newColor) {
assert(value != null); assert(newColor != null);
if (_color == value) if (_color == newColor)
return; return;
_color = value; _color = newColor;
markNeedsPaint(); markNeedsPaint();
} }
sky.TransferMode _transferMode; sky.TransferMode _transferMode;
sky.TransferMode get transferMode => _transferMode; sky.TransferMode get transferMode => _transferMode;
void set transferMode (sky.TransferMode value) { void set transferMode (sky.TransferMode newTransferMode) {
assert(value != null); assert(newTransferMode != null);
if (_transferMode == value) if (_transferMode == newTransferMode)
return; return;
_transferMode = value; _transferMode = newTransferMode;
markNeedsPaint(); markNeedsPaint();
} }
...@@ -342,21 +342,21 @@ class RenderClipRRect extends RenderProxyBox { ...@@ -342,21 +342,21 @@ class RenderClipRRect extends RenderProxyBox {
double _xRadius; double _xRadius;
double get xRadius => _xRadius; double get xRadius => _xRadius;
void set xRadius (double value) { void set xRadius (double newXRadius) {
assert(value != null); assert(newXRadius != null);
if (_xRadius == value) if (_xRadius == newXRadius)
return; return;
_xRadius = value; _xRadius = newXRadius;
markNeedsPaint(); markNeedsPaint();
} }
double _yRadius; double _yRadius;
double get yRadius => _yRadius; double get yRadius => _yRadius;
void set yRadius (double value) { void set yRadius (double newYRadius) {
assert(value != null); assert(newYRadius != null);
if (_yRadius == value) if (_yRadius == newYRadius)
return; return;
_yRadius = value; _yRadius = newYRadius;
markNeedsPaint(); markNeedsPaint();
} }
...@@ -408,12 +408,12 @@ class RenderDecoratedBox extends RenderProxyBox { ...@@ -408,12 +408,12 @@ class RenderDecoratedBox extends RenderProxyBox {
final BoxPainter _painter; final BoxPainter _painter;
BoxDecoration get decoration => _painter.decoration; BoxDecoration get decoration => _painter.decoration;
void set decoration (BoxDecoration value) { void set decoration (BoxDecoration newDecoration) {
assert(value != null); assert(newDecoration != null);
if (value == _painter.decoration) if (newDecoration == _painter.decoration)
return; return;
_removeBackgroundImageListenerIfNeeded(); _removeBackgroundImageListenerIfNeeded();
_painter.decoration = value; _painter.decoration = newDecoration;
_addBackgroundImageListenerIfNeeded(); _addBackgroundImageListenerIfNeeded();
markNeedsPaint(); markNeedsPaint();
} }
...@@ -468,11 +468,11 @@ class RenderTransform extends RenderProxyBox { ...@@ -468,11 +468,11 @@ class RenderTransform extends RenderProxyBox {
Matrix4 _transform; Matrix4 _transform;
void set transform(Matrix4 value) { void set transform(Matrix4 newTransform) {
assert(value != null); assert(newTransform != null);
if (_transform == value) if (_transform == newTransform)
return; return;
_transform = new Matrix4.copy(value); _transform = new Matrix4.copy(newTransform);
markNeedsPaint(); markNeedsPaint();
} }
...@@ -569,11 +569,11 @@ class RenderCustomPaint extends RenderProxyBox { ...@@ -569,11 +569,11 @@ class RenderCustomPaint extends RenderProxyBox {
} }
CustomPaintCallback _callback; CustomPaintCallback _callback;
void set callback (CustomPaintCallback value) { void set callback (CustomPaintCallback newCallback) {
assert(value != null || !attached); assert(newCallback != null || !attached);
if (_callback == value) if (_callback == newCallback)
return; return;
_callback = value; _callback = newCallback;
markNeedsPaint(); markNeedsPaint();
} }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment