Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
61b5caff
Unverified
Commit
61b5caff
authored
Apr 01, 2019
by
Zachary Anderson
Committed by
GitHub
Apr 01, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[fuchsia_tester] Plumb through the location of icudtl (#30218)
parent
97622353
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
12 additions
and
2 deletions
+12
-2
fuchsia_tester.dart
packages/flutter_tools/bin/fuchsia_tester.dart
+2
-2
flutter_platform.dart
packages/flutter_tools/lib/src/test/flutter_platform.dart
+8
-0
runner.dart
packages/flutter_tools/lib/src/test/runner.dart
+2
-0
No files found.
packages/flutter_tools/bin/fuchsia_tester.dart
View file @
61b5caff
...
...
@@ -99,8 +99,7 @@ Future<void> run(List<String> args) async {
fs
.
link
(
artifacts
.
getArtifactPath
(
Artifact
.
flutterTester
));
testerDestLink
.
parent
.
createSync
(
recursive:
true
);
testerDestLink
.
createSync
(
fs
.
path
.
absolute
(
shellPath
));
final
Link
icudtlLink
=
testerDestLink
.
parent
.
childLink
(
'icudtl.dat'
);
icudtlLink
.
createSync
(
fs
.
path
.
absolute
(
argResults
[
_kOptionIcudtl
]));
final
Directory
sdkRootDest
=
fs
.
directory
(
artifacts
.
getArtifactPath
(
Artifact
.
flutterPatchedSdkPath
));
sdkRootDest
.
createSync
(
recursive:
true
);
...
...
@@ -141,6 +140,7 @@ Future<void> run(List<String> args) async {
enableObservatory:
collector
!=
null
,
precompiledDillFiles:
tests
,
concurrency:
math
.
max
(
1
,
platform
.
numberOfProcessors
-
2
),
icudtlPath:
fs
.
path
.
absolute
(
argResults
[
_kOptionIcudtl
]),
);
if
(
collector
!=
null
)
{
...
...
packages/flutter_tools/lib/src/test/flutter_platform.dart
View file @
61b5caff
...
...
@@ -92,6 +92,7 @@ void installHook({
InternetAddressType
serverType
=
InternetAddressType
.
IPv4
,
Uri
projectRootDirectory
,
FlutterProject
flutterProject
,
String
icudtlPath
,
})
{
assert
(
enableObservatory
||
(!
startPaused
&&
observatoryPort
==
null
));
hack
.
registerPlatformPlugin
(
...
...
@@ -111,6 +112,7 @@ void installHook({
updateGoldens:
updateGoldens
,
projectRootDirectory:
projectRootDirectory
,
flutterProject:
flutterProject
,
icudtlPath:
icudtlPath
,
),
);
}
...
...
@@ -390,6 +392,7 @@ class _FlutterPlatform extends PlatformPlugin {
this
.
updateGoldens
,
this
.
projectRootDirectory
,
this
.
flutterProject
,
this
.
icudtlPath
,
})
:
assert
(
shellPath
!=
null
);
final
String
shellPath
;
...
...
@@ -406,6 +409,7 @@ class _FlutterPlatform extends PlatformPlugin {
final
bool
updateGoldens
;
final
Uri
projectRootDirectory
;
final
FlutterProject
flutterProject
;
final
String
icudtlPath
;
Directory
fontsDirectory
;
_Compiler
compiler
;
...
...
@@ -952,6 +956,10 @@ class _FlutterPlatform extends PlatformPlugin {
command
.
add
(
'--ipv6'
);
}
if
(
icudtlPath
!=
null
)
{
command
.
add
(
'--icu-data-file-path=
$icudtlPath
'
);
}
command
.
addAll
(<
String
>[
'--enable-checked-mode'
,
'--verify-entry-points'
,
...
...
packages/flutter_tools/lib/src/test/runner.dart
View file @
61b5caff
...
...
@@ -36,6 +36,7 @@ Future<int> runTests(
TestWatcher
watcher
,
@required
int
concurrency
,
FlutterProject
flutterProject
,
String
icudtlPath
,
})
async
{
// Compute the command-line arguments for package:test.
final
List
<
String
>
testArgs
=
<
String
>[];
...
...
@@ -83,6 +84,7 @@ Future<int> runTests(
updateGoldens:
updateGoldens
,
projectRootDirectory:
fs
.
currentDirectory
.
uri
,
flutterProject:
flutterProject
,
icudtlPath:
icudtlPath
,
);
// Make the global packages path absolute.
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment