Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
553662d1
Unverified
Commit
553662d1
authored
Oct 26, 2019
by
Jonah Williams
Committed by
GitHub
Oct 26, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Catch AppConnectionException from dwds (#43544)
parent
be53209e
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
9 deletions
+8
-9
resident_web_runner.dart
...utter_tools/lib/src/build_runner/resident_web_runner.dart
+6
-7
resident_web_runner_test.dart
...er_tools/test/general.shard/resident_web_runner_test.dart
+2
-2
No files found.
packages/flutter_tools/lib/src/build_runner/resident_web_runner.dart
View file @
553662d1
...
...
@@ -234,15 +234,14 @@ class ResidentWebRunner extends ResidentRunner {
throwToolExit
(
'Failed to establish connection with Chrome. Try running the application again.
\n
'
'If this problem persists, please file an issue with the details below:
\n
$err
\n
$stackTrace
'
);
}
on
AppConnectionException
{
throwToolExit
(
'Failed to establish connection with the application instance in Chrome.
\n
'
'This can happen if the websocket connection used by the web tooling is '
'unabled to correctly establish a connection, for example due to a firewall.'
);
}
on
SocketException
catch
(
err
)
{
throwToolExit
(
err
.
toString
());
}
on
StateError
catch
(
err
)
{
// Handle known state error.
final
String
message
=
err
.
toString
();
if
(
message
.
contains
(
'Could not connect to application with appInstanceId'
))
{
throwToolExit
(
message
);
}
rethrow
;
}
finally
{
if
(
statusActive
)
{
buildStatus
.
stop
();
...
...
packages/flutter_tools/test/general.shard/resident_web_runner_test.dart
View file @
553662d1
...
...
@@ -565,13 +565,13 @@ void main() {
await
expectation
;
}));
test
(
'Successfully turns App
InstanceId error
into ToolExit'
,
()
=>
testbed
.
run
(()
async
{
test
(
'Successfully turns App
ConnectionException
into ToolExit'
,
()
=>
testbed
.
run
(()
async
{
_setupMocks
();
final
Completer
<
DebugConnectionInfo
>
connectionInfoCompleter
=
Completer
<
DebugConnectionInfo
>();
final
Completer
<
void
>
unhandledErrorCompleter
=
Completer
<
void
>();
when
(
mockWebFs
.
connect
(
any
)).
thenAnswer
((
Invocation
_
)
async
{
unawaited
(
unhandledErrorCompleter
.
future
.
then
((
void
value
)
{
throw
StateError
(
'Could not connect to application with appInstanceId: c0ae0750-ee91-11e9-cea6-35d95a968356'
);
throw
AppConnectionException
(
'Could not connect to application with appInstanceId: c0ae0750-ee91-11e9-cea6-35d95a968356'
);
}));
return
ConnectionResult
(
mockAppConnection
,
mockDebugConnection
);
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment