Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
5506cc5b
Unverified
Commit
5506cc5b
authored
Nov 14, 2019
by
Casey Hillers
Committed by
GitHub
Nov 14, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Remove no longer needed clean up code (#44408)
parent
e77c24ef
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
0 additions
and
10 deletions
+0
-10
heroes_test.dart
packages/flutter/test/widgets/heroes_test.dart
+0
-10
No files found.
packages/flutter/test/widgets/heroes_test.dart
View file @
5506cc5b
...
...
@@ -479,11 +479,6 @@ Future<void> main() async {
Navigator
.
pop
(
heroes
.
evaluate
().
first
);
await
tester
.
pump
();
// ...and removes it straight away (since it's already at 0.0)
// this is verifying that there's no crash
// TODO(ianh): once https://github.com/flutter/flutter/issues/5631 is fixed, remove this line:
await
tester
.
pump
(
const
Duration
(
hours:
1
));
});
testWidgets
(
'Overlapping starting and ending a hero transition works ok'
,
(
WidgetTester
tester
)
async
{
...
...
@@ -513,11 +508,6 @@ Future<void> main() async {
Navigator
.
pop
(
heroes
.
evaluate
().
first
);
await
tester
.
pump
(
const
Duration
(
hours:
1
));
// so the first transition is finished, but the second hasn't started
await
tester
.
pump
();
// this is verifying that there's no crash
// TODO(ianh): once https://github.com/flutter/flutter/issues/5631 is fixed, remove this line:
await
tester
.
pump
(
const
Duration
(
hours:
1
));
});
testWidgets
(
'One route, two heroes, same tag, throws'
,
(
WidgetTester
tester
)
async
{
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment