Unverified Commit 5414ef4c authored by Elliott Brooks (she/her)'s avatar Elliott Brooks (she/her) Committed by GitHub

Hide unresolved DartUri log messages (#102338)

parent ca3b406c
......@@ -1009,6 +1009,16 @@ void _log(logging.LogRecord event) {
if (event.level >= logging.Level.SEVERE) {
globals.printError('${event.loggerName}: ${event.message}$error', stackTrace: event.stackTrace);
} else if (event.level == logging.Level.WARNING) {
// TODO(elliette): Remove the following message suppressions after DWDS is
// >13.1.0, https://github.com/flutter/flutter/issues/101639
const String dartUri = 'DartUri';
if (event.loggerName == dartUri) {
const String webSqlWarning = 'Unresolved uri: dart:web_sql';
const String uiWarning = 'Unresolved uri: dart:ui';
if (event.message == webSqlWarning || event.message == uiWarning) {
return;
}
}
globals.printWarning('${event.loggerName}: ${event.message}$error');
} else {
globals.printTrace('${event.loggerName}: ${event.message}$error');
......
......@@ -78,4 +78,18 @@ void main() {
await sendEvent(<String, Object>{'type': 'DevtoolsEvent'});
await warning;
}, skip: true); // Skipping for 'https://github.com/dart-lang/webdev/issues/1562'
testWithoutContext(
'flutter run output skips DartUri warning messages from dwds', () async {
bool containsDartUriWarning = false;
flutter.stderr.listen((String msg) {
if (msg.contains('DartUri')) {
containsDartUriWarning = true;
}
});
await start();
await flutter.stop();
expect(containsDartUriWarning, isFalse);
// TODO(elliette): Enable for DWDS >13.1.0, https://github.com/flutter/flutter/issues/101639
}, skip: true); // [intended] enable for DWDS >13.1.0
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment