Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
5414ef4c
Unverified
Commit
5414ef4c
authored
Apr 22, 2022
by
Elliott Brooks (she/her)
Committed by
GitHub
Apr 22, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Hide unresolved DartUri log messages (#102338)
parent
ca3b406c
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
24 additions
and
0 deletions
+24
-0
devfs_web.dart
packages/flutter_tools/lib/src/isolated/devfs_web.dart
+10
-0
output_web_test.dart
packages/flutter_tools/test/web.shard/output_web_test.dart
+14
-0
No files found.
packages/flutter_tools/lib/src/isolated/devfs_web.dart
View file @
5414ef4c
...
...
@@ -1009,6 +1009,16 @@ void _log(logging.LogRecord event) {
if
(
event
.
level
>=
logging
.
Level
.
SEVERE
)
{
globals
.
printError
(
'
${event.loggerName}
:
${event.message}$error
'
,
stackTrace:
event
.
stackTrace
);
}
else
if
(
event
.
level
==
logging
.
Level
.
WARNING
)
{
// TODO(elliette): Remove the following message suppressions after DWDS is
// >13.1.0, https://github.com/flutter/flutter/issues/101639
const
String
dartUri
=
'DartUri'
;
if
(
event
.
loggerName
==
dartUri
)
{
const
String
webSqlWarning
=
'Unresolved uri: dart:web_sql'
;
const
String
uiWarning
=
'Unresolved uri: dart:ui'
;
if
(
event
.
message
==
webSqlWarning
||
event
.
message
==
uiWarning
)
{
return
;
}
}
globals
.
printWarning
(
'
${event.loggerName}
:
${event.message}$error
'
);
}
else
{
globals
.
printTrace
(
'
${event.loggerName}
:
${event.message}$error
'
);
...
...
packages/flutter_tools/test/web.shard/output_web_test.dart
View file @
5414ef4c
...
...
@@ -78,4 +78,18 @@ void main() {
await
sendEvent
(<
String
,
Object
>{
'type'
:
'DevtoolsEvent'
});
await
warning
;
},
skip:
true
);
// Skipping for 'https://github.com/dart-lang/webdev/issues/1562'
testWithoutContext
(
'flutter run output skips DartUri warning messages from dwds'
,
()
async
{
bool
containsDartUriWarning
=
false
;
flutter
.
stderr
.
listen
((
String
msg
)
{
if
(
msg
.
contains
(
'DartUri'
))
{
containsDartUriWarning
=
true
;
}
});
await
start
();
await
flutter
.
stop
();
expect
(
containsDartUriWarning
,
isFalse
);
// TODO(elliette): Enable for DWDS >13.1.0, https://github.com/flutter/flutter/issues/101639
},
skip:
true
);
// [intended] enable for DWDS >13.1.0
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment