Unverified Commit 53d45258 authored by Dan Field's avatar Dan Field Committed by GitHub

Speculative fix for #29262 (#29273)

* Avoid writing to stderr before process has finished streaming
parent 96cb84a1
...@@ -55,7 +55,7 @@ Stream<String> runAndGetStdout(String executable, List<String> arguments, { ...@@ -55,7 +55,7 @@ Stream<String> runAndGetStdout(String executable, List<String> arguments, {
await for (String line in lines) { await for (String line in lines) {
yield line; yield line;
} }
await stderr.addStream(process.stderr);
final int exitCode = await process.exitCode.timeout(timeout, onTimeout: () { final int exitCode = await process.exitCode.timeout(timeout, onTimeout: () {
stderr.writeln('Process timed out after $timeout'); stderr.writeln('Process timed out after $timeout');
return expectNonZeroExit ? 0 : 1; return expectNonZeroExit ? 0 : 1;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment