Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
535392bf
Unverified
Commit
535392bf
authored
Jan 08, 2021
by
Michael Goderbauer
Committed by
GitHub
Jan 08, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
added tests, removed API (#69620)
parent
ddc0dc13
Changes
8
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
236 additions
and
89 deletions
+236
-89
fix_data.yaml
packages/flutter/lib/fix_data.yaml
+143
-0
framework.dart
packages/flutter/lib/src/widgets/framework.dart
+31
-87
cupertino.dart
packages/flutter/test_fixes/cupertino.dart
+10
-0
cupertino.dart.expect
packages/flutter/test_fixes/cupertino.dart.expect
+10
-0
material.dart
packages/flutter/test_fixes/material.dart
+10
-0
material.dart.expect
packages/flutter/test_fixes/material.dart.expect
+12
-2
widgets.dart
packages/flutter/test_fixes/widgets.dart
+10
-0
widgets.dart.expect
packages/flutter/test_fixes/widgets.dart.expect
+10
-0
No files found.
packages/flutter/lib/fix_data.yaml
View file @
535392bf
...
...
@@ -11,6 +11,149 @@
version
:
1
transforms
:
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Rename
to
dependOnInheritedElement'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
inheritFromElement'
changes
:
-
kind
:
'
rename'
newName
:
'
dependOnInheritedElement'
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Migrate
to
dependOnInheritedWidgetOfExactType'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
inheritFromWidgetOfExactType'
changes
:
-
kind
:
'
rename'
newName
:
'
dependOnInheritedWidgetOfExactType'
-
kind
:
'
removeParameter'
index
:
0
-
kind
:
'
addTypeParameter'
index
:
0
name
:
'
T'
argumentValue
:
expression
:
'
{%
type
%}'
variables
:
type
:
kind
:
fragment
value
:
'
arguments[0]'
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Migrate
to
getElementForInheritedWidgetOfExactType'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
ancestorInheritedElementForWidgetOfExactType'
changes
:
-
kind
:
'
rename'
newName
:
'
getElementForInheritedWidgetOfExactType'
-
kind
:
'
removeParameter'
index
:
0
-
kind
:
'
addTypeParameter'
index
:
0
name
:
'
T'
argumentValue
:
expression
:
'
{%
type
%}'
variables
:
type
:
kind
:
fragment
value
:
'
arguments[0]'
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Migrate
to
findAncestorWidgetOfExactType'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
ancestorWidgetOfExactType'
changes
:
-
kind
:
'
rename'
newName
:
'
findAncestorWidgetOfExactType'
-
kind
:
'
removeParameter'
index
:
0
-
kind
:
'
addTypeParameter'
index
:
0
name
:
'
T'
argumentValue
:
expression
:
'
{%
type
%}'
variables
:
type
:
kind
:
fragment
value
:
'
arguments[0]'
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Migrate
to
findAncestorStateOfType'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
ancestorStateOfType'
changes
:
-
kind
:
'
rename'
newName
:
'
findAncestorStateOfType'
-
kind
:
'
removeParameter'
index
:
0
-
kind
:
'
addTypeParameter'
index
:
0
name
:
'
T'
argumentValue
:
expression
:
'
{%
type
%}'
variables
:
type
:
kind
:
fragment
value
:
'
arguments[0].typeArguments[0]'
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Migrate
to
rootAncestorStateOfType'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
rootAncestorStateOfType'
changes
:
-
kind
:
'
rename'
newName
:
'
findRootAncestorStateOfType'
-
kind
:
'
removeParameter'
index
:
0
-
kind
:
'
addTypeParameter'
index
:
0
name
:
'
T'
argumentValue
:
expression
:
'
{%
type
%}'
variables
:
type
:
kind
:
fragment
value
:
'
arguments[0].typeArguments[0]'
# Change made in https://github.com/flutter/flutter/pull/44189.
-
title
:
'
Migrate
to
ancestorRenderObjectOfType'
date
:
2019-11-22
element
:
uris
:
[
'
material.dart'
,
'
cupertino.dart'
,
'
widgets.dart'
]
inClass
:
'
BuildContext'
method
:
'
ancestorRenderObjectOfType'
changes
:
-
kind
:
'
rename'
newName
:
'
findAncestorRenderObjectOfType'
-
kind
:
'
removeParameter'
index
:
0
-
kind
:
'
addTypeParameter'
index
:
0
name
:
'
T'
argumentValue
:
expression
:
'
{%
type
%}'
variables
:
type
:
kind
:
fragment
value
:
'
arguments[0].typeArguments[0]'
# Changes made in https://github.com/flutter/flutter/pull/45941
-
title
:
'
Rename
to
deferFirstFrame'
date
:
2020-12-23
...
...
packages/flutter/lib/src/widgets/framework.dart
View file @
535392bf
This diff is collapsed.
Click to expand it.
packages/flutter/test_fixes/cupertino.dart
View file @
535392bf
...
...
@@ -17,4 +17,14 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/44189
const
StatefulElement
statefulElement
=
StatefulElement
(
myWidget
);
statefulElement
.
inheritFromElement
(
ancestor
);
// Changes made in https://github.com/flutter/flutter/pull/44189
const
BuildContext
buildContext
=
Element
(
myWidget
);
buildContext
.
inheritFromElement
(
ancestor
);
buildContext
.
inheritFromWidgetOfExactType
(
targetType
);
buildContext
.
ancestorInheritedElementForWidgetOfExactType
(
targetType
);
buildContext
.
ancestorWidgetOfExactType
(
targetType
);
buildContext
.
ancestorStateOfType
(
TypeMatcher
<
targetType
>());
buildContext
.
rootAncestorStateOfType
(
TypeMatcher
<
targetType
>());
buildContext
.
ancestorRenderObjectOfType
(
TypeMatcher
<
targetType
>());
}
packages/flutter/test_fixes/cupertino.dart.expect
View file @
535392bf
...
...
@@ -17,4 +17,14 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/44189
const StatefulElement statefulElement = StatefulElement(myWidget);
statefulElement.dependOnInheritedElement(ancestor);
// Changes made in https://github.com/flutter/flutter/pull/44189
const BuildContext buildContext = Element(myWidget);
buildContext.dependOnInheritedElement(ancestor);
buildContext.dependOnInheritedWidgetOfExactType<targetType>();
buildContext.getElementForInheritedWidgetOfExactType<targetType>();
buildContext.findAncestorWidgetOfExactType<targetType>();
buildContext.findAncestorStateOfType<targetType>();
buildContext.findRootAncestorStateOfType<targetType>();
buildContext.findAncestorRenderObjectOfType<targetType>();
}
packages/flutter/test_fixes/material.dart
View file @
535392bf
...
...
@@ -16,4 +16,14 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/44189
const
StatefulElement
statefulElement
=
StatefulElement
(
myWidget
);
statefulElement
.
inheritFromElement
(
ancestor
);
// Changes made in https://github.com/flutter/flutter/pull/44189
const
BuildContext
buildContext
=
Element
(
myWidget
);
buildContext
.
inheritFromElement
(
ancestor
);
buildContext
.
inheritFromWidgetOfExactType
(
targetType
);
buildContext
.
ancestorInheritedElementForWidgetOfExactType
(
targetType
);
buildContext
.
ancestorWidgetOfExactType
(
targetType
);
buildContext
.
ancestorStateOfType
(
TypeMatcher
<
targetType
>());
buildContext
.
rootAncestorStateOfType
(
TypeMatcher
<
targetType
>());
buildContext
.
ancestorRenderObjectOfType
(
TypeMatcher
<
targetType
>());
}
packages/flutter/test_fixes/material.dart.expect
View file @
535392bf
...
...
@@ -14,6 +14,16 @@ void main() {
binding.allowFirstFrame();
// Changes made in https://github.com/flutter/flutter/pull/44189
const StatefulElement statefulElement = StatefulElement(myWidget);
statefulElement.dependOnInheritedElement(ancestor);
const StatefulElement statefulElement = StatefulElement(myWidget);
statefulElement.dependOnInheritedElement(ancestor);
// Changes made in https://github.com/flutter/flutter/pull/44189
const BuildContext buildContext = Element(myWidget);
buildContext.dependOnInheritedElement(ancestor);
buildContext.dependOnInheritedWidgetOfExactType<targetType>();
buildContext.getElementForInheritedWidgetOfExactType<targetType>();
buildContext.findAncestorWidgetOfExactType<targetType>();
buildContext.findAncestorStateOfType<targetType>();
buildContext.findRootAncestorStateOfType<targetType>();
buildContext.findAncestorRenderObjectOfType<targetType>();
}
packages/flutter/test_fixes/widgets.dart
View file @
535392bf
...
...
@@ -13,4 +13,14 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/44189
const
StatefulElement
statefulElement
=
StatefulElement
(
myWidget
);
statefulElement
.
inheritFromElement
(
ancestor
);
// Changes made in https://github.com/flutter/flutter/pull/44189
const
BuildContext
buildContext
=
Element
(
myWidget
);
buildContext
.
inheritFromElement
(
ancestor
);
buildContext
.
inheritFromWidgetOfExactType
(
targetType
);
buildContext
.
ancestorInheritedElementForWidgetOfExactType
(
targetType
);
buildContext
.
ancestorWidgetOfExactType
(
targetType
);
buildContext
.
ancestorStateOfType
(
TypeMatcher
<
targetType
>());
buildContext
.
rootAncestorStateOfType
(
TypeMatcher
<
targetType
>());
buildContext
.
ancestorRenderObjectOfType
(
TypeMatcher
<
targetType
>());
}
packages/flutter/test_fixes/widgets.dart.expect
View file @
535392bf
...
...
@@ -13,4 +13,14 @@ void main() {
// Changes made in https://github.com/flutter/flutter/pull/44189
const StatefulElement statefulElement = StatefulElement(myWidget);
statefulElement.dependOnInheritedElement(ancestor);
// Changes made in https://github.com/flutter/flutter/pull/44189
const BuildContext buildContext = Element(myWidget);
buildContext.dependOnInheritedElement(ancestor);
buildContext.dependOnInheritedWidgetOfExactType<targetType>();
buildContext.getElementForInheritedWidgetOfExactType<targetType>();
buildContext.findAncestorWidgetOfExactType<targetType>();
buildContext.findAncestorStateOfType<targetType>();
buildContext.findRootAncestorStateOfType<targetType>();
buildContext.findAncestorRenderObjectOfType<targetType>();
}
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment