Unverified Commit 504963b4 authored by Tianguang's avatar Tianguang Committed by GitHub

Pin gallery version (#62986)

parent 762d9f7f
......@@ -10,6 +10,7 @@ import 'package:path/path.dart' as path;
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/framework/utils.dart';
import 'package:flutter_devicelab/versions/gallery.dart' show galleryVersion;
Future<void> main() async {
await task(const NewGalleryChromeRunTest().run);
......@@ -36,9 +37,14 @@ class NewGalleryChromeRunTest {
/// Runs the test.
Future<TaskResult> run() async {
await gitClone(path: 'temp', repo: galleryRepo);
final Directory galleryParentDir =
Directory.systemTemp.createTempSync('temp');
final Directory galleryDir =
Directory(path.join(galleryParentDir.path, 'gallery'));
final TaskResult result = await inDirectory<TaskResult>('temp/gallery', () async {
await getNewGallery(galleryVersion, galleryDir);
final TaskResult result = await inDirectory<TaskResult>(galleryDir, () async {
await flutter('doctor');
await flutter('packages', options: <String>['get']);
......@@ -102,7 +108,7 @@ class NewGalleryChromeRunTest {
}
});
rmTree(Directory('temp'));
rmTree(galleryParentDir);
return result;
}
......
......@@ -4,8 +4,11 @@
import 'dart:io';
import 'package:path/path.dart' as path;
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/framework/utils.dart';
import 'package:flutter_devicelab/versions/gallery.dart' show galleryVersion;
import 'package:flutter_devicelab/tasks/perf_tests.dart' show WebCompileTest;
......@@ -22,22 +25,27 @@ class NewGalleryWebCompileTest {
/// Runs the test.
Future<TaskResult> run() async {
await gitClone(path: 'temp', repo: 'https://github.com/flutter/gallery.git');
final Directory galleryParentDir =
Directory.systemTemp.createTempSync('temp');
final Directory galleryDir =
Directory(path.join(galleryParentDir.path, 'gallery'));
await getNewGallery(galleryVersion, galleryDir);
final Map<String, Object> metrics = await inDirectory<Map<String, int>>(
'temp/gallery',
galleryDir,
() async {
await flutter('doctor');
return await WebCompileTest.runSingleBuildTest(
directory: 'temp/gallery',
directory: galleryDir.path,
metric: metricKeyPrefix,
measureBuildTime: true,
);
},
);
rmTree(Directory('temp'));
rmTree(galleryParentDir);
return TaskResult.success(metrics, benchmarkScoreKeys: metrics.keys.toList());
}
......
......@@ -10,6 +10,7 @@ import 'package:flutter_devicelab/tasks/perf_tests.dart';
import '../framework/framework.dart';
import '../framework/utils.dart';
import '../versions/gallery.dart' show galleryVersion;
class NewGalleryPerfTest extends PerfTest {
NewGalleryPerfTest(
......@@ -28,7 +29,7 @@ class NewGalleryPerfTest extends PerfTest {
// Manually roll the new gallery version for now. If the new gallery repo
// turns out to be updated frequently in the future, we can set up an auto
// roller to update this version.
await getNewGallery('a208eac6e6e8336ae9820e54c572c099231f1da2', galleryDir);
await getNewGallery(galleryVersion, galleryDir);
return await super.run();
}
......
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/// The pinned version of flutter gallery, used for devicelab tests.
const String galleryVersion = 'a208eac6e6e8336ae9820e54c572c099231f1da2';
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment