Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4fe41abf
Unverified
Commit
4fe41abf
authored
Jan 29, 2019
by
Konstantin Scheglov
Committed by
GitHub
Jan 29, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Add default values for optional parameters. (#27197)
parent
1811d574
Changes
18
Hide whitespace changes
Inline
Side-by-side
Showing
18 changed files
with
25 additions
and
25 deletions
+25
-25
object.dart
packages/flutter/lib/src/rendering/object.dart
+2
-2
decoration_test.dart
packages/flutter/test/painting/decoration_test.dart
+1
-1
image_stream_test.dart
packages/flutter/test/painting/image_stream_test.dart
+1
-1
paint_image_test.dart
packages/flutter/test/painting/paint_image_test.dart
+1
-1
shape_decoration_test.dart
packages/flutter/test/painting/shape_decoration_test.dart
+1
-1
image_test.dart
packages/flutter/test/rendering/image_test.dart
+3
-3
recording_canvas.dart
packages/flutter/test/rendering/recording_canvas.dart
+1
-1
image_resolution_test.dart
packages/flutter/test/widgets/image_resolution_test.dart
+1
-1
image_rtl_test.dart
packages/flutter/test/widgets/image_rtl_test.dart
+1
-1
image_test.dart
packages/flutter/test/widgets/image_test.dart
+1
-1
list_view_test.dart
packages/flutter/test/widgets/list_view_test.dart
+1
-1
binding.dart
packages/flutter_test/lib/src/binding.dart
+1
-1
build_kernel_compiler.dart
...ter_tools/lib/src/build_runner/build_kernel_compiler.dart
+1
-1
daemon.dart
packages/flutter_tools/lib/src/commands/daemon.dart
+3
-3
fuchsia_device.dart
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
+1
-1
build_test.dart
packages/flutter_tools/test/base/build_test.dart
+1
-1
crash_reporting_test.dart
packages/flutter_tools/test/crash_reporting_test.dart
+2
-2
emulator_test.dart
packages/flutter_tools/test/emulator_test.dart
+2
-2
No files found.
packages/flutter/lib/src/rendering/object.dart
View file @
4fe41abf
...
@@ -2595,7 +2595,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
...
@@ -2595,7 +2595,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
}
}
@override
@override
String
toString
({
DiagnosticLevel
minLevel
})
=>
toStringShort
();
String
toString
({
DiagnosticLevel
minLevel
=
DiagnosticLevel
.
debug
})
=>
toStringShort
();
/// Returns a description of the tree rooted at this node.
/// Returns a description of the tree rooted at this node.
/// If the prefix argument is provided, then every line in the output
/// If the prefix argument is provided, then every line in the output
...
@@ -2631,7 +2631,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
...
@@ -2631,7 +2631,7 @@ abstract class RenderObject extends AbstractNode with DiagnosticableTreeMixin im
/// [toStringDeep], but does not recurse to any children.
/// [toStringDeep], but does not recurse to any children.
@override
@override
String
toStringShallow
({
String
toStringShallow
({
String
joiner
=
'
;
'
,
String
joiner
=
'
,
'
,
DiagnosticLevel
minLevel
=
DiagnosticLevel
.
debug
,
DiagnosticLevel
minLevel
=
DiagnosticLevel
.
debug
,
})
{
})
{
RenderObject
debugPreviousActiveLayout
;
RenderObject
debugPreviousActiveLayout
;
...
...
packages/flutter/test/painting/decoration_test.dart
View file @
4fe41abf
...
@@ -85,7 +85,7 @@ class TestImage implements ui.Image {
...
@@ -85,7 +85,7 @@ class TestImage implements ui.Image {
void
dispose
()
{
}
void
dispose
()
{
}
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
}
}
...
...
packages/flutter/test/painting/image_stream_test.dart
View file @
4fe41abf
...
@@ -40,7 +40,7 @@ class FakeImage implements Image {
...
@@ -40,7 +40,7 @@ class FakeImage implements Image {
void
dispose
()
{}
void
dispose
()
{}
@override
@override
Future
<
ByteData
>
toByteData
({
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ImageByteFormat
format
=
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
}
}
...
...
packages/flutter/test/painting/paint_image_test.dart
View file @
4fe41abf
...
@@ -23,7 +23,7 @@ class TestImage implements ui.Image {
...
@@ -23,7 +23,7 @@ class TestImage implements ui.Image {
void
dispose
()
{
}
void
dispose
()
{
}
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
}
}
...
...
packages/flutter/test/painting/shape_decoration_test.dart
View file @
4fe41abf
...
@@ -125,7 +125,7 @@ class TestImage implements ui.Image {
...
@@ -125,7 +125,7 @@ class TestImage implements ui.Image {
void
dispose
()
{
}
void
dispose
()
{
}
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
}
}
packages/flutter/test/rendering/image_test.dart
View file @
4fe41abf
...
@@ -19,7 +19,7 @@ class SquareImage implements ui.Image {
...
@@ -19,7 +19,7 @@ class SquareImage implements ui.Image {
int
get
height
=>
10
;
int
get
height
=>
10
;
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
...
@@ -38,7 +38,7 @@ class WideImage implements ui.Image {
...
@@ -38,7 +38,7 @@ class WideImage implements ui.Image {
int
get
height
=>
10
;
int
get
height
=>
10
;
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
...
@@ -57,7 +57,7 @@ class TallImage implements ui.Image {
...
@@ -57,7 +57,7 @@ class TallImage implements ui.Image {
int
get
height
=>
20
;
int
get
height
=>
20
;
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
...
...
packages/flutter/test/rendering/recording_canvas.dart
View file @
4fe41abf
...
@@ -103,7 +103,7 @@ class TestRecordingPaintingContext extends ClipContext implements PaintingContex
...
@@ -103,7 +103,7 @@ class TestRecordingPaintingContext extends ClipContext implements PaintingContex
}
}
@override
@override
void
pushClipRect
(
bool
needsCompositing
,
Offset
offset
,
Rect
clipRect
,
PaintingContextCallback
painter
,
{
Clip
clipBehavior
=
Clip
.
antiAlias
})
{
void
pushClipRect
(
bool
needsCompositing
,
Offset
offset
,
Rect
clipRect
,
PaintingContextCallback
painter
,
{
Clip
clipBehavior
=
Clip
.
hardEdge
})
{
clipRectAndPaint
(
clipRect
.
shift
(
offset
),
clipBehavior
,
clipRect
.
shift
(
offset
),
()
=>
painter
(
this
,
offset
));
clipRectAndPaint
(
clipRect
.
shift
(
offset
),
clipBehavior
,
clipRect
.
shift
(
offset
),
()
=>
painter
(
this
,
offset
));
}
}
...
...
packages/flutter/test/widgets/image_resolution_test.dart
View file @
4fe41abf
...
@@ -26,7 +26,7 @@ class TestImage implements ui.Image {
...
@@ -26,7 +26,7 @@ class TestImage implements ui.Image {
void
dispose
()
{
}
void
dispose
()
{
}
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
}
}
...
...
packages/flutter/test/widgets/image_rtl_test.dart
View file @
4fe41abf
...
@@ -37,7 +37,7 @@ class TestImage implements ui.Image {
...
@@ -37,7 +37,7 @@ class TestImage implements ui.Image {
void
dispose
()
{
}
void
dispose
()
{
}
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
}
}
...
...
packages/flutter/test/widgets/image_test.dart
View file @
4fe41abf
...
@@ -926,7 +926,7 @@ class TestImage implements ui.Image {
...
@@ -926,7 +926,7 @@ class TestImage implements ui.Image {
void
dispose
()
{
}
void
dispose
()
{
}
@override
@override
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
})
async
{
Future
<
ByteData
>
toByteData
({
ui
.
ImageByteFormat
format
=
ui
.
ImageByteFormat
.
rawRgba
})
async
{
throw
UnsupportedError
(
'Cannot encode test image'
);
throw
UnsupportedError
(
'Cannot encode test image'
);
}
}
...
...
packages/flutter/test/widgets/list_view_test.dart
View file @
4fe41abf
...
@@ -27,7 +27,7 @@ class Alive extends StatefulWidget {
...
@@ -27,7 +27,7 @@ class Alive extends StatefulWidget {
AliveState
createState
()
=>
AliveState
();
AliveState
createState
()
=>
AliveState
();
@override
@override
String
toString
({
DiagnosticLevel
minLevel
})
=>
'
$index
$alive
'
;
String
toString
({
DiagnosticLevel
minLevel
=
DiagnosticLevel
.
debug
})
=>
'
$index
$alive
'
;
}
}
class
AliveState
extends
State
<
Alive
>
with
AutomaticKeepAliveClientMixin
{
class
AliveState
extends
State
<
Alive
>
with
AutomaticKeepAliveClientMixin
{
...
...
packages/flutter_test/lib/src/binding.dart
View file @
4fe41abf
...
@@ -720,7 +720,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
...
@@ -720,7 +720,7 @@ class AutomatedTestWidgetsFlutterBinding extends TestWidgetsFlutterBinding {
@override
@override
Future
<
T
>
runAsync
<
T
>(
Future
<
T
>
callback
(),
{
Future
<
T
>
runAsync
<
T
>(
Future
<
T
>
callback
(),
{
Duration
additionalTime
=
const
Duration
(
milliseconds:
100
0
),
Duration
additionalTime
=
const
Duration
(
milliseconds:
25
0
),
})
{
})
{
assert
(
additionalTime
!=
null
);
assert
(
additionalTime
!=
null
);
assert
(()
{
assert
(()
{
...
...
packages/flutter_tools/lib/src/build_runner/build_kernel_compiler.dart
View file @
4fe41abf
...
@@ -33,7 +33,7 @@ class BuildKernelCompiler implements KernelCompiler {
...
@@ -33,7 +33,7 @@ class BuildKernelCompiler implements KernelCompiler {
List
<
String
>
fileSystemRoots
,
List
<
String
>
fileSystemRoots
,
String
fileSystemScheme
,
String
fileSystemScheme
,
String
depFilePath
,
String
depFilePath
,
TargetModel
targetModel
,
TargetModel
targetModel
=
TargetModel
.
flutter
,
})
async
{
})
async
{
if
(
fileSystemRoots
!=
null
||
fileSystemScheme
!=
null
||
depFilePath
!=
null
||
targetModel
!=
null
||
sdkRoot
!=
null
||
packagesPath
!=
null
)
{
if
(
fileSystemRoots
!=
null
||
fileSystemScheme
!=
null
||
depFilePath
!=
null
||
targetModel
!=
null
||
sdkRoot
!=
null
||
packagesPath
!=
null
)
{
printTrace
(
'fileSystemRoots, fileSystemScheme, depFilePath, targetModel,'
printTrace
(
'fileSystemRoots, fileSystemScheme, depFilePath, targetModel,'
...
...
packages/flutter_tools/lib/src/commands/daemon.dart
View file @
4fe41abf
...
@@ -784,7 +784,7 @@ class NotifyingLogger extends Logger {
...
@@ -784,7 +784,7 @@ class NotifyingLogger extends Logger {
String
message
,
{
String
message
,
{
@required
Duration
timeout
,
@required
Duration
timeout
,
String
progressId
,
String
progressId
,
bool
multilineOutput
,
bool
multilineOutput
=
false
,
int
progressIndicatorPadding
=
kDefaultStatusPadding
,
int
progressIndicatorPadding
=
kDefaultStatusPadding
,
})
{
})
{
assert
(
timeout
!=
null
);
assert
(
timeout
!=
null
);
...
@@ -961,8 +961,8 @@ class _AppRunLogger extends Logger {
...
@@ -961,8 +961,8 @@ class _AppRunLogger extends Logger {
String
message
,
{
String
message
,
{
@required
Duration
timeout
,
@required
Duration
timeout
,
String
progressId
,
String
progressId
,
bool
multilineOutput
,
bool
multilineOutput
=
false
,
int
progressIndicatorPadding
=
52
,
int
progressIndicatorPadding
=
kDefaultStatusPadding
,
})
{
})
{
assert
(
timeout
!=
null
);
assert
(
timeout
!=
null
);
final
int
id
=
_nextProgressId
++;
final
int
id
=
_nextProgressId
++;
...
...
packages/flutter_tools/lib/src/fuchsia/fuchsia_device.dart
View file @
4fe41abf
...
@@ -185,7 +185,7 @@ class FuchsiaDevice extends Device {
...
@@ -185,7 +185,7 @@ class FuchsiaDevice extends Device {
Map
<
String
,
dynamic
>
platformArgs
,
Map
<
String
,
dynamic
>
platformArgs
,
bool
prebuiltApplication
=
false
,
bool
prebuiltApplication
=
false
,
bool
applicationNeedsRebuild
=
false
,
bool
applicationNeedsRebuild
=
false
,
bool
usesTerminalUi
=
fals
e
,
bool
usesTerminalUi
=
tru
e
,
bool
ipv6
=
false
,
bool
ipv6
=
false
,
})
=>
Future
<
void
>.
error
(
'unimplemented'
);
})
=>
Future
<
void
>.
error
(
'unimplemented'
);
...
...
packages/flutter_tools/test/base/build_test.dart
View file @
4fe41abf
...
@@ -55,7 +55,7 @@ class _FakeGenSnapshot implements GenSnapshot {
...
@@ -55,7 +55,7 @@ class _FakeGenSnapshot implements GenSnapshot {
String
packagesPath
,
String
packagesPath
,
String
depfilePath
,
String
depfilePath
,
IOSArch
iosArch
,
IOSArch
iosArch
,
Iterable
<
String
>
additionalArgs
,
Iterable
<
String
>
additionalArgs
=
const
<
String
>[]
,
})
async
{
})
async
{
_callCount
+=
1
;
_callCount
+=
1
;
_snapshotType
=
snapshotType
;
_snapshotType
=
snapshotType
;
...
...
packages/flutter_tools/test/crash_reporting_test.dart
View file @
4fe41abf
...
@@ -216,10 +216,10 @@ class _NoopIOSink implements IOSink {
...
@@ -216,10 +216,10 @@ class _NoopIOSink implements IOSink {
void
write
(
_
)
{}
void
write
(
_
)
{}
@override
@override
void
writeAll
(
_
,
[
__
])
{}
void
writeAll
(
_
,
[
__
=
''
])
{}
@override
@override
void
writeln
([
_
])
{}
void
writeln
([
_
=
''
])
{}
@override
@override
void
writeCharCode
(
_
)
{}
void
writeCharCode
(
_
)
{}
...
...
packages/flutter_tools/test/emulator_test.dart
View file @
4fe41abf
...
@@ -203,8 +203,8 @@ class MockProcessManager extends Mock implements ProcessManager {
...
@@ -203,8 +203,8 @@ class MockProcessManager extends Mock implements ProcessManager {
Map
<
String
,
String
>
environment
,
Map
<
String
,
String
>
environment
,
bool
includeParentEnvironment
=
true
,
bool
includeParentEnvironment
=
true
,
bool
runInShell
=
false
,
bool
runInShell
=
false
,
Encoding
stdoutEncoding
,
Encoding
stdoutEncoding
=
systemEncoding
,
Encoding
stderrEncoding
Encoding
stderrEncoding
=
systemEncoding
})
{
})
{
final
String
program
=
command
[
0
];
final
String
program
=
command
[
0
];
final
List
<
String
>
args
=
command
.
sublist
(
1
);
final
List
<
String
>
args
=
command
.
sublist
(
1
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment