Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4f2e3217
Unverified
Commit
4f2e3217
authored
Jul 28, 2022
by
xubaolin
Committed by
GitHub
Jul 28, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
fix a tabs indicator padding update bug (#108287)
parent
07de84f0
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
30 additions
and
0 deletions
+30
-0
tabs.dart
packages/flutter/lib/src/material/tabs.dart
+1
-0
tabs_test.dart
packages/flutter/test/material/tabs_test.dart
+29
-0
No files found.
packages/flutter/lib/src/material/tabs.dart
View file @
4f2e3217
...
...
@@ -1024,6 +1024,7 @@ class _TabBarState extends State<TabBar> {
}
else
if
(
widget
.
indicatorColor
!=
oldWidget
.
indicatorColor
||
widget
.
indicatorWeight
!=
oldWidget
.
indicatorWeight
||
widget
.
indicatorSize
!=
oldWidget
.
indicatorSize
||
widget
.
indicatorPadding
!=
oldWidget
.
indicatorPadding
||
widget
.
indicator
!=
oldWidget
.
indicator
)
{
_initIndicatorPainter
();
}
...
...
packages/flutter/test/material/tabs_test.dart
View file @
4f2e3217
...
...
@@ -238,6 +238,35 @@ void main() {
debugResetSemanticsIdCounter
();
});
testWidgets
(
'indicatorPadding update test'
,
(
WidgetTester
tester
)
async
{
// Regressing test for https://github.com/flutter/flutter/issues/108102
const
Tab
tab
=
Tab
(
text:
'A'
);
const
EdgeInsets
indicatorPadding
=
EdgeInsets
.
only
(
left:
7.0
,
right:
7.0
);
await
tester
.
pumpWidget
(
boilerplate
(
child:
const
DefaultTabController
(
length:
1
,
child:
TabBar
(
tabs:
<
Tab
>[
tab
],
indicatorPadding:
indicatorPadding
,
),
),
));
// Change the indicatorPadding
await
tester
.
pumpWidget
(
boilerplate
(
child:
DefaultTabController
(
length:
1
,
child:
TabBar
(
tabs:
const
<
Tab
>[
tab
],
indicatorPadding:
indicatorPadding
+
const
EdgeInsets
.
all
(
7.0
),
),
),
),
Duration
.
zero
,
EnginePhase
.
build
);
expect
(
tester
.
renderObject
(
find
.
byType
(
CustomPaint
)).
debugNeedsPaint
,
true
);
});
testWidgets
(
'Tab sizing - icon'
,
(
WidgetTester
tester
)
async
{
await
tester
.
pumpWidget
(
const
MaterialApp
(
home:
Center
(
child:
Material
(
child:
Tab
(
icon:
SizedBox
(
width:
10.0
,
height:
10.0
))))),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment