Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4ef6fc18
Unverified
Commit
4ef6fc18
authored
Oct 07, 2021
by
Jenn Magder
Committed by
GitHub
Oct 07, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Update number of IPHONEOS_DEPLOYMENT_TARGET in plugin_test_ios (#91324)
parent
3e334945
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
8 additions
and
12 deletions
+8
-12
plugin_tests.dart
dev/devicelab/lib/tasks/plugin_tests.dart
+8
-12
No files found.
dev/devicelab/lib/tasks/plugin_tests.dart
View file @
4ef6fc18
...
...
@@ -173,25 +173,21 @@ class _FlutterProject {
final
String
podsProjectContent
=
podsProject
.
readAsStringSync
();
if
(
target
==
'ios'
)
{
// This may be a bit brittle, IPHONEOS_DEPLOYMENT_TARGET appears in the
// Pods Xcode project file 6 times. If this number changes, make sure
// it's not a regression in the IPHONEOS_DEPLOYMENT_TARGET override logic.
// The plugintest target should not have IPHONEOS_DEPLOYMENT_TARGET set.
// See _reduceDarwinPluginMinimumVersion for details.
final
int
iosDeploymentTargetCount
=
'IPHONEOS_DEPLOYMENT_TARGET'
.
allMatches
(
podsProjectContent
).
length
;
if
(
iosDeploymentTargetCount
!=
9
)
{
throw
TaskResult
.
failure
(
'plugintest may contain IPHONEOS_DEPLOYMENT_TARGET,
$iosDeploymentTargetCount
found'
);
// Plugins with versions lower than the app version should not have IPHONEOS_DEPLOYMENT_TARGET set.
// The plugintest plugin target should not have IPHONEOS_DEPLOYMENT_TARGET set since it has been lowered
// in _reduceDarwinPluginMinimumVersion to 7, which is below the target version of 9.
if
(
podsProjectContent
.
contains
(
'IPHONEOS_DEPLOYMENT_TARGET = 7'
))
{
throw
TaskResult
.
failure
(
'Plugin build setting IPHONEOS_DEPLOYMENT_TARGET not removed'
);
}
if
(!
podsProjectContent
.
contains
(
r'"EXCLUDED_ARCHS[sdk=iphonesimulator*]" = "$(inherited) i386";'
))
{
throw
TaskResult
.
failure
(
r'EXCLUDED_ARCHS is not "$(inherited) i386"'
);
}
}
// Same for macOS
, but 12
.
// Same for macOS
deployment target, but 10.8
.
// The plugintest target should not have MACOSX_DEPLOYMENT_TARGET set.
final
int
macosDeploymentTargetCount
=
'MACOSX_DEPLOYMENT_TARGET'
.
allMatches
(
podsProjectContent
).
length
;
if
(
target
==
'macos'
&&
macosDeploymentTargetCount
!=
12
)
{
throw
TaskResult
.
failure
(
'plugintest may contain MACOSX_DEPLOYMENT_TARGET,
$macosDeploymentTargetCount
found'
);
if
(
target
==
'macos'
&&
podsProjectContent
.
contains
(
'MACOSX_DEPLOYMENT_TARGET = 10.8'
))
{
throw
TaskResult
.
failure
(
'Plugin build setting MACOSX_DEPLOYMENT_TARGET not removed'
);
}
}
});
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment