Unverified Commit 4e6de2be authored by Andrew Kolos's avatar Andrew Kolos Committed by GitHub

remove unused `firstBuildTime` parameter in `DevFS::update` (#144576)

The title says it all. This parameter is unused and serves no apparent purpose.
parent 4e71b4d8
...@@ -571,7 +571,6 @@ class DevFS { ...@@ -571,7 +571,6 @@ class DevFS {
DevFSWriter? devFSWriter, DevFSWriter? devFSWriter,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool fullRestart = false, bool fullRestart = false,
File? dartPluginRegistrant, File? dartPluginRegistrant,
......
...@@ -873,7 +873,6 @@ class WebDevFS implements DevFS { ...@@ -873,7 +873,6 @@ class WebDevFS implements DevFS {
DevFSWriter? devFSWriter, DevFSWriter? devFSWriter,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool fullRestart = false, bool fullRestart = false,
String? projectRootPath, String? projectRootPath,
......
...@@ -129,7 +129,6 @@ class ResidentWebRunner extends ResidentRunner { ...@@ -129,7 +129,6 @@ class ResidentWebRunner extends ResidentRunner {
FlutterDevice? get device => flutterDevices.first; FlutterDevice? get device => flutterDevices.first;
final FlutterProject flutterProject; final FlutterProject flutterProject;
DateTime? firstBuildTime;
// Used with the new compiler to generate a bootstrap file containing plugins // Used with the new compiler to generate a bootstrap file containing plugins
// and platform initialization. // and platform initialization.
...@@ -241,7 +240,6 @@ class ResidentWebRunner extends ResidentRunner { ...@@ -241,7 +240,6 @@ class ResidentWebRunner extends ResidentRunner {
bool enableDevTools = false, // ignored, we don't yet support devtools for web bool enableDevTools = false, // ignored, we don't yet support devtools for web
String? route, String? route,
}) async { }) async {
firstBuildTime = DateTime.now();
final ApplicationPackage? package = await ApplicationPackageFactory.instance!.getPackageForPlatform( final ApplicationPackage? package = await ApplicationPackageFactory.instance!.getPackageForPlatform(
TargetPlatform.web_javascript, TargetPlatform.web_javascript,
buildInfo: debuggingOptions.buildInfo, buildInfo: debuggingOptions.buildInfo,
...@@ -567,7 +565,6 @@ Please provide a valid TCP port (an integer between 0 and 65535, inclusive). ...@@ -567,7 +565,6 @@ Please provide a valid TCP port (an integer between 0 and 65535, inclusive).
), ),
target: target, target: target,
bundle: assetBundle, bundle: assetBundle,
firstBuildTime: firstBuildTime,
bundleFirstUpload: isFirstUpload, bundleFirstUpload: isFirstUpload,
generator: device!.generator!, generator: device!.generator!,
fullRestart: fullRestart, fullRestart: fullRestart,
......
...@@ -556,7 +556,6 @@ class FlutterDevice { ...@@ -556,7 +556,6 @@ class FlutterDevice {
required Uri mainUri, required Uri mainUri,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool bundleDirty = false, bool bundleDirty = false,
bool fullRestart = false, bool fullRestart = false,
...@@ -574,7 +573,6 @@ class FlutterDevice { ...@@ -574,7 +573,6 @@ class FlutterDevice {
mainUri: mainUri, mainUri: mainUri,
target: target, target: target,
bundle: bundle, bundle: bundle,
firstBuildTime: firstBuildTime,
bundleFirstUpload: bundleFirstUpload, bundleFirstUpload: bundleFirstUpload,
generator: generator!, generator: generator!,
fullRestart: fullRestart, fullRestart: fullRestart,
......
...@@ -132,8 +132,6 @@ class HotRunner extends ResidentRunner { ...@@ -132,8 +132,6 @@ class HotRunner extends ResidentRunner {
final Map<String, List<int>> benchmarkData = <String, List<int>>{}; final Map<String, List<int>> benchmarkData = <String, List<int>>{};
DateTime? firstBuildTime;
String? _targetPlatform; String? _targetPlatform;
String? _sdkName; String? _sdkName;
bool? _emulator; bool? _emulator;
...@@ -384,7 +382,6 @@ class HotRunner extends ResidentRunner { ...@@ -384,7 +382,6 @@ class HotRunner extends ResidentRunner {
final Stopwatch appStartedTimer = Stopwatch()..start(); final Stopwatch appStartedTimer = Stopwatch()..start();
final File mainFile = globals.fs.file(mainPath); final File mainFile = globals.fs.file(mainPath);
firstBuildTime = DateTime.now();
Duration totalCompileTime = Duration.zero; Duration totalCompileTime = Duration.zero;
Duration totalLaunchAppTime = Duration.zero; Duration totalLaunchAppTime = Duration.zero;
...@@ -532,7 +529,6 @@ class HotRunner extends ResidentRunner { ...@@ -532,7 +529,6 @@ class HotRunner extends ResidentRunner {
mainUri: entrypointFile.absolute.uri, mainUri: entrypointFile.absolute.uri,
target: target, target: target,
bundle: assetBundle, bundle: assetBundle,
firstBuildTime: firstBuildTime,
bundleFirstUpload: isFirstUpload, bundleFirstUpload: isFirstUpload,
bundleDirty: !isFirstUpload && rebuildBundle, bundleDirty: !isFirstUpload && rebuildBundle,
fullRestart: fullRestart, fullRestart: fullRestart,
......
...@@ -118,7 +118,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice { ...@@ -118,7 +118,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice {
Uri? mainUri, Uri? mainUri,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool bundleDirty = false, bool bundleDirty = false,
bool fullRestart = false, bool fullRestart = false,
......
...@@ -280,7 +280,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice { ...@@ -280,7 +280,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice {
required Uri mainUri, required Uri mainUri,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool bundleDirty = false, bool bundleDirty = false,
bool fullRestart = false, bool fullRestart = false,
...@@ -518,7 +517,6 @@ class FakeDevFS extends Fake implements DevFS { ...@@ -518,7 +517,6 @@ class FakeDevFS extends Fake implements DevFS {
DevFSWriter? devFSWriter, DevFSWriter? devFSWriter,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool fullRestart = false, bool fullRestart = false,
String? projectRootPath, String? projectRootPath,
......
...@@ -1562,7 +1562,6 @@ class FakeWebDevFS extends Fake implements WebDevFS { ...@@ -1562,7 +1562,6 @@ class FakeWebDevFS extends Fake implements WebDevFS {
DevFSWriter? devFSWriter, DevFSWriter? devFSWriter,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool fullRestart = false, bool fullRestart = false,
String? projectRootPath, String? projectRootPath,
...@@ -1731,7 +1730,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice { ...@@ -1731,7 +1730,6 @@ class FakeFlutterDevice extends Fake implements FlutterDevice {
Uri? mainUri, Uri? mainUri,
String? target, String? target,
AssetBundle? bundle, AssetBundle? bundle,
DateTime? firstBuildTime,
bool bundleFirstUpload = false, bool bundleFirstUpload = false,
bool bundleDirty = false, bool bundleDirty = false,
bool fullRestart = false, bool fullRestart = false,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment