Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4dec56b2
Unverified
Commit
4dec56b2
authored
Jun 08, 2022
by
Bruno Leroux
Committed by
GitHub
Jun 08, 2022
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Fix PageView throws Null check error (#104405)
parent
f377f61f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
53 additions
and
0 deletions
+53
-0
page_view.dart
packages/flutter/lib/src/widgets/page_view.dart
+14
-0
page_view_test.dart
packages/flutter/test/widgets/page_view_test.dart
+39
-0
No files found.
packages/flutter/lib/src/widgets/page_view.dart
View file @
4dec56b2
...
...
@@ -462,6 +462,20 @@ class _PagePosition extends ScrollPositionWithSingleContext implements PageMetri
return
result
;
}
@override
void
absorb
(
ScrollPosition
other
)
{
super
.
absorb
(
other
);
assert
(
_cachedPage
==
null
);
if
(
other
is
!
_PagePosition
)
{
return
;
}
if
(
other
.
_cachedPage
!=
null
)
{
_cachedPage
=
other
.
_cachedPage
;
}
}
@override
bool
applyContentDimensions
(
double
minScrollExtent
,
double
maxScrollExtent
)
{
final
double
newMinScrollExtent
=
minScrollExtent
+
_initialPageOffset
;
...
...
packages/flutter/test/widgets/page_view_test.dart
View file @
4dec56b2
...
...
@@ -133,6 +133,45 @@ void main() {
expect
(
find
.
text
(
'Illinois'
),
findsOneWidget
);
});
testWidgets
(
'_PagePosition.applyViewportDimension should not throw'
,
(
WidgetTester
tester
)
async
{
// Regression test for https://github.com/flutter/flutter/issues/101007
final
PageController
controller
=
PageController
(
initialPage:
1
,
);
// Set the starting viewportDimension to 0.0
await
tester
.
binding
.
setSurfaceSize
(
Size
.
zero
);
final
MediaQueryData
mediaQueryData
=
MediaQueryData
.
fromWindow
(
tester
.
binding
.
window
);
Widget
build
(
Size
size
)
{
return
MediaQuery
(
data:
mediaQueryData
.
copyWith
(
size:
size
),
child:
Directionality
(
textDirection:
TextDirection
.
ltr
,
child:
Center
(
child:
SizedBox
.
expand
(
child:
PageView
(
controller:
controller
,
onPageChanged:
(
int
page
)
{
},
children:
kStates
.
map
<
Widget
>((
String
state
)
=>
Text
(
state
)).
toList
(),
),
),
),
),
);
}
await
tester
.
pumpWidget
(
build
(
Size
.
zero
));
const
Size
surfaceSize
=
Size
(
500
,
400
);
await
tester
.
binding
.
setSurfaceSize
(
surfaceSize
);
await
tester
.
pumpWidget
(
build
(
surfaceSize
));
expect
(
tester
.
takeException
(),
isNull
);
// Reset TestWidgetsFlutterBinding surfaceSize
await
tester
.
binding
.
setSurfaceSize
(
null
);
});
testWidgets
(
'PageController cannot return page while unattached'
,
(
WidgetTester
tester
)
async
{
final
PageController
controller
=
PageController
();
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment