Commit 4d0debd4 authored by Devon Carew's avatar Devon Carew Committed by GitHub

fix some call sites of printError (#11724)

* fix some call sites of printError

* review comments
parent 5f9acc41
...@@ -468,7 +468,7 @@ abstract class ResidentRunner { ...@@ -468,7 +468,7 @@ abstract class ResidentRunner {
await view.uiIsolate.flutterDebugAllowBanner(false); await view.uiIsolate.flutterDebugAllowBanner(false);
} catch (error) { } catch (error) {
status.stop(); status.stop();
printError(error); printError('Error communicating with Flutter on the device: $error');
} }
} }
try { try {
...@@ -480,7 +480,7 @@ abstract class ResidentRunner { ...@@ -480,7 +480,7 @@ abstract class ResidentRunner {
await view.uiIsolate.flutterDebugAllowBanner(true); await view.uiIsolate.flutterDebugAllowBanner(true);
} catch (error) { } catch (error) {
status.stop(); status.stop();
printError(error); printError('Error communicating with Flutter on the device: $error');
} }
} }
} }
......
...@@ -88,7 +88,7 @@ class ColdRunner extends ResidentRunner { ...@@ -88,7 +88,7 @@ class ColdRunner extends ResidentRunner {
try { try {
await downloadStartupTrace(device.vmServices.first); await downloadStartupTrace(device.vmServices.first);
} catch (error) { } catch (error) {
printError(error); printError('Error downloading startup trace: $error');
return 2; return 2;
} }
} }
......
...@@ -31,8 +31,8 @@ Future<Null> parseServiceConfigs( ...@@ -31,8 +31,8 @@ Future<Null> parseServiceConfigs(
Map<String, Uri> packageMap; Map<String, Uri> packageMap;
try { try {
packageMap = new PackageMap(PackageMap.globalPackagesPath).map; packageMap = new PackageMap(PackageMap.globalPackagesPath).map;
} on FormatException catch(e) { } on FormatException catch (error) {
printTrace('Invalid ".packages" file while parsing service configs:\n$e'); printTrace('Invalid ".packages" file while parsing service configs:\n$error');
return; return;
} }
...@@ -40,9 +40,9 @@ Future<Null> parseServiceConfigs( ...@@ -40,9 +40,9 @@ Future<Null> parseServiceConfigs(
try { try {
manifest = _loadYamlFile(_kFlutterManifestPath); manifest = _loadYamlFile(_kFlutterManifestPath);
manifest = manifest['flutter']; manifest = manifest['flutter'];
} catch (e) { } catch (error) {
printStatus('Error detected in pubspec.yaml:', emphasis: true); printStatus('Error detected in pubspec.yaml:', emphasis: true);
printError(e); printError('$error');
return; return;
} }
if (manifest == null || manifest['services'] == null) { if (manifest == null || manifest['services'] == null) {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment