Skip to content

F
Front-End
Unverified Commit 4c5db40f authored by Michael Goderbauer's avatar Michael Goderbauer Committed by GitHub
Browse files
Options

Clean-up viewId casts in flutter_test (#128256) 

Follow-up to https://github.com/flutter/engine/pull/42493.
parent ffab83e6
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 4 deletions
packages/flutter_test/lib/src/window.dart
View file @ 4c5db40f
...@@ -678,8 +678,7 @@ class TestFlutterView implements FlutterView { ...@@ -678,8 +678,7 @@ class TestFlutterView implements FlutterView {
final TestDisplay _display; final TestDisplay _display;
@override @override
// TODO(goderbauer): Clean ignore and cast up after https://github.com/flutter/engine/pull/42493 lands. int get viewId => _view.viewId;
int get viewId => _view.viewId as int; // ignore: unnecessary_cast
/// The device pixel ratio to use for this test. /// The device pixel ratio to use for this test.
/// ///
...@@ -2089,8 +2088,7 @@ class TestWindow implements SingletonFlutterWindow { ...@@ -2089,8 +2088,7 @@ class TestWindow implements SingletonFlutterWindow {
'This feature was deprecated after v3.9.0-0.1.pre.' 'This feature was deprecated after v3.9.0-0.1.pre.'
) )
@override @override
// TODO(goderbauer): Clean ignore and cast up after https://github.com/flutter/engine/pull/42493 lands. int get viewId => _view.viewId;
int get viewId => _view.viewId as int; // ignore: unnecessary_cast
/// This gives us some grace time when the dart:ui side adds something to /// This gives us some grace time when the dart:ui side adds something to
/// [SingletonFlutterWindow], and makes things easier when we do rolls to give /// [SingletonFlutterWindow], and makes things easier when we do rolls to give
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment

HIAST - GitLab