Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4c5db40f
Unverified
Commit
4c5db40f
authored
Jun 06, 2023
by
Michael Goderbauer
Committed by
GitHub
Jun 06, 2023
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Clean-up viewId casts in flutter_test (#128256)
Follow-up to
https://github.com/flutter/engine/pull/42493
.
parent
ffab83e6
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
2 additions
and
4 deletions
+2
-4
window.dart
packages/flutter_test/lib/src/window.dart
+2
-4
No files found.
packages/flutter_test/lib/src/window.dart
View file @
4c5db40f
...
@@ -678,8 +678,7 @@ class TestFlutterView implements FlutterView {
...
@@ -678,8 +678,7 @@ class TestFlutterView implements FlutterView {
final
TestDisplay
_display
;
final
TestDisplay
_display
;
@override
@override
// TODO(goderbauer): Clean ignore and cast up after https://github.com/flutter/engine/pull/42493 lands.
int
get
viewId
=>
_view
.
viewId
;
int
get
viewId
=>
_view
.
viewId
as
int
;
// ignore: unnecessary_cast
/// The device pixel ratio to use for this test.
/// The device pixel ratio to use for this test.
///
///
...
@@ -2089,8 +2088,7 @@ class TestWindow implements SingletonFlutterWindow {
...
@@ -2089,8 +2088,7 @@ class TestWindow implements SingletonFlutterWindow {
'This feature was deprecated after v3.9.0-0.1.pre.'
'This feature was deprecated after v3.9.0-0.1.pre.'
)
)
@override
@override
// TODO(goderbauer): Clean ignore and cast up after https://github.com/flutter/engine/pull/42493 lands.
int
get
viewId
=>
_view
.
viewId
;
int
get
viewId
=>
_view
.
viewId
as
int
;
// ignore: unnecessary_cast
/// This gives us some grace time when the dart:ui side adds something to
/// This gives us some grace time when the dart:ui side adds something to
/// [SingletonFlutterWindow], and makes things easier when we do rolls to give
/// [SingletonFlutterWindow], and makes things easier when we do rolls to give
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment