Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
49249693
Unverified
Commit
49249693
authored
May 13, 2021
by
godofredoc
Committed by
GitHub
May 13, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Turn on win_build_tests_2_3 shard, skip 'build windows' tests (#82386)" (#82396)
This reverts commit
a66e5a7f
.
parent
adb3f138
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
18 additions
and
2 deletions
+18
-2
test.dart
dev/bots/test.dart
+17
-1
try_builders.json
dev/try_builders.json
+1
-1
No files found.
dev/bots/test.dart
View file @
49249693
...
@@ -442,7 +442,8 @@ Future<void> _runExampleProjectBuildTests(FileSystemEntity exampleDirectory) asy
...
@@ -442,7 +442,8 @@ Future<void> _runExampleProjectBuildTests(FileSystemEntity exampleDirectory) asy
}
}
if
(
Platform
.
isWindows
)
{
if
(
Platform
.
isWindows
)
{
if
(
Directory
(
path
.
join
(
examplePath
,
'windows'
)).
existsSync
())
{
if
(
Directory
(
path
.
join
(
examplePath
,
'windows'
)).
existsSync
())
{
// TODO(jmagman): Re-add Windows build tests when Visual Studio is available https://github.com/flutter/flutter/issues/81956.
await
_flutterBuildWin32
(
examplePath
,
release:
false
,
additionalArgs:
additionalArgs
,
verifyCaching:
verifyCaching
);
await
_flutterBuildWin32
(
examplePath
,
release:
true
,
additionalArgs:
additionalArgs
,
verifyCaching:
verifyCaching
);
}
else
{
}
else
{
print
(
'Example project
${path.basename(examplePath)}
has no windows directory, skipping Win32'
);
print
(
'Example project
${path.basename(examplePath)}
has no windows directory, skipping Win32'
);
}
}
...
@@ -506,6 +507,21 @@ Future<void> _flutterBuildMacOS(String relativePathToApplication, {
...
@@ -506,6 +507,21 @@ Future<void> _flutterBuildMacOS(String relativePathToApplication, {
);
);
}
}
Future
<
void
>
_flutterBuildWin32
(
String
relativePathToApplication
,
{
@required
bool
release
,
bool
verifyCaching
=
false
,
List
<
String
>
additionalArgs
=
const
<
String
>[],
})
async
{
assert
(
Platform
.
isWindows
);
await
runCommand
(
flutter
,
<
String
>[
'config'
,
'--enable-windows-desktop'
]);
print
(
'
${green}
Testing Windows build
$reset
for
$cyan$relativePathToApplication$reset
...'
);
await
_flutterBuild
(
relativePathToApplication
,
'Windows'
,
'windows'
,
release:
release
,
verifyCaching:
verifyCaching
,
additionalArgs:
additionalArgs
);
}
Future
<
void
>
_flutterBuild
(
Future
<
void
>
_flutterBuild
(
String
relativePathToApplication
,
String
relativePathToApplication
,
String
platformLabel
,
String
platformLabel
,
...
...
dev/try_builders.json
View file @
49249693
...
@@ -579,7 +579,7 @@
...
@@ -579,7 +579,7 @@
"name"
:
"Windows build_tests_2_3"
,
"name"
:
"Windows build_tests_2_3"
,
"repo"
:
"flutter"
,
"repo"
:
"flutter"
,
"task_name"
:
"win_build_tests_2_3"
,
"task_name"
:
"win_build_tests_2_3"
,
"enabled"
:
tru
e
"enabled"
:
fals
e
},
},
{
{
"name"
:
"Windows build_tests_3_3"
,
"name"
:
"Windows build_tests_3_3"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment