Unverified Commit 48207838 authored by Jonah Williams's avatar Jonah Williams Committed by GitHub

make sure we exit early if the Runner.xcodeproj file is missing (#31591)

parent 8cfc9246
......@@ -318,8 +318,13 @@ abstract class IOSApp extends ApplicationPackage {
if (getCurrentHostPlatform() != HostPlatform.darwin_x64) {
return null;
}
// TODO(jonahwilliams): do more verification in this check.
if (!project.exists) {
// If the project doesn't exist at all the existing hint to run flutter
// create is accurate.
return null;
}
if (!project.xcodeProject.existsSync()) {
printError('Expected ios/Runner.xcodeproj but this file is missing.');
return null;
}
return BuildableIOSApp(project);
......
......@@ -285,6 +285,15 @@ void main() {
expect(iosApp, null);
}, overrides: overrides);
testUsingContext('returns null when there is no Runner.xcodeproj', () async {
fs.file('pubspec.yaml').createSync();
fs.file('.packages').createSync();
fs.file('ios/FooBar.xcodeproj').createSync(recursive: true);
final BuildableIOSApp iosApp = IOSApp.fromIosProject((await FlutterProject.fromDirectory(fs.currentDirectory)).ios);
expect(iosApp, null);
}, overrides: overrides);
});
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment