Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
48207838
Unverified
Commit
48207838
authored
Apr 25, 2019
by
Jonah Williams
Committed by
GitHub
Apr 25, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
make sure we exit early if the Runner.xcodeproj file is missing (#31591)
parent
8cfc9246
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletion
+15
-1
application_package.dart
packages/flutter_tools/lib/src/application_package.dart
+6
-1
application_package_test.dart
packages/flutter_tools/test/application_package_test.dart
+9
-0
No files found.
packages/flutter_tools/lib/src/application_package.dart
View file @
48207838
...
...
@@ -318,8 +318,13 @@ abstract class IOSApp extends ApplicationPackage {
if
(
getCurrentHostPlatform
()
!=
HostPlatform
.
darwin_x64
)
{
return
null
;
}
// TODO(jonahwilliams): do more verification in this check.
if
(!
project
.
exists
)
{
// If the project doesn't exist at all the existing hint to run flutter
// create is accurate.
return
null
;
}
if
(!
project
.
xcodeProject
.
existsSync
())
{
printError
(
'Expected ios/Runner.xcodeproj but this file is missing.'
);
return
null
;
}
return
BuildableIOSApp
(
project
);
...
...
packages/flutter_tools/test/application_package_test.dart
View file @
48207838
...
...
@@ -285,6 +285,15 @@ void main() {
expect
(
iosApp
,
null
);
},
overrides:
overrides
);
testUsingContext
(
'returns null when there is no Runner.xcodeproj'
,
()
async
{
fs
.
file
(
'pubspec.yaml'
).
createSync
();
fs
.
file
(
'.packages'
).
createSync
();
fs
.
file
(
'ios/FooBar.xcodeproj'
).
createSync
(
recursive:
true
);
final
BuildableIOSApp
iosApp
=
IOSApp
.
fromIosProject
((
await
FlutterProject
.
fromDirectory
(
fs
.
currentDirectory
)).
ios
);
expect
(
iosApp
,
null
);
},
overrides:
overrides
);
});
}
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment