Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
45ae4f6d
Unverified
Commit
45ae4f6d
authored
Jul 22, 2019
by
Devon Carew
Committed by
GitHub
Jul 22, 2019
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
use sentence case in error message titles (#35750)
* use sentence case in error message titles * add a test
parent
b79136ba
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletion
+15
-1
assertions.dart
packages/flutter/lib/src/foundation/assertions.dart
+1
-1
assertions_test.dart
packages/flutter/test/foundation/assertions_test.dart
+14
-0
No files found.
packages/flutter/lib/src/foundation/assertions.dart
View file @
45ae4f6d
...
@@ -459,7 +459,7 @@ class FlutterErrorDetails extends Diagnosticable {
...
@@ -459,7 +459,7 @@ class FlutterErrorDetails extends Diagnosticable {
@override
@override
String
toStringShort
()
{
String
toStringShort
()
{
return
library
!=
null
?
'Exception
Caught By
$library
'
:
'Exception C
aught'
;
return
library
!=
null
?
'Exception
caught by
$library
'
:
'Exception c
aught'
;
}
}
@override
@override
...
...
packages/flutter/test/foundation/assertions_test.dart
View file @
45ae4f6d
...
@@ -122,6 +122,20 @@ void main() {
...
@@ -122,6 +122,20 @@ void main() {
);
);
});
});
test
(
'FlutterErrorDetails.toStringShort'
,
()
{
expect
(
FlutterErrorDetails
(
exception:
'MESSAGE'
,
library
:
'library'
,
context:
ErrorDescription
(
'CONTEXTING'
),
informationCollector:
()
sync
*
{
yield
ErrorDescription
(
'INFO'
);
},
).
toStringShort
(),
'Exception caught by library'
,
);
});
test
(
'FlutterError default constructor'
,
()
{
test
(
'FlutterError default constructor'
,
()
{
FlutterError
error
=
FlutterError
(
FlutterError
error
=
FlutterError
(
'My Error Summary.
\n
'
'My Error Summary.
\n
'
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment