Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
4471282d
Unverified
Commit
4471282d
authored
Apr 01, 2021
by
Jia Hao
Committed by
GitHub
Apr 01, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
[flutter_tools] Normalize paths before checking for Integration Tests (#79521)
parent
132b071f
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
22 additions
and
1 deletion
+22
-1
test.dart
packages/flutter_tools/lib/src/commands/test.dart
+1
-1
test_test.dart
...flutter_tools/test/commands.shard/hermetic/test_test.dart
+21
-0
No files found.
packages/flutter_tools/lib/src/commands/test.dart
View file @
4471282d
...
...
@@ -273,7 +273,7 @@ class TestCommand extends FlutterCommand with DeviceBasedDevelopmentArtifacts {
if
(
globals
.
fs
.
isDirectorySync
(
path
))
...
_findTests
(
globals
.
fs
.
directory
(
path
))
else
globals
.
fs
.
path
.
absolute
(
path
)
globals
.
fs
.
path
.
normalize
(
globals
.
fs
.
path
.
absolute
(
path
)
)
];
}
...
...
packages/flutter_tools/test/commands.shard/hermetic/test_test.dart
View file @
4471282d
...
...
@@ -446,6 +446,27 @@ dev_dependencies:
]),
});
testUsingContext
(
'when absolute unnormalized path to integration test is passed'
,
()
async
{
final
FakePackageTest
fakePackageTest
=
FakePackageTest
();
final
TestCommand
testCommand
=
TestCommand
(
testWrapper:
fakePackageTest
);
final
CommandRunner
<
void
>
commandRunner
=
createTestCommandRunner
(
testCommand
);
await
commandRunner
.
run
(
const
<
String
>[
'test'
,
'--no-pub'
,
'/package/../package/integration_test/some_integration_test.dart'
,
]);
expect
(
testCommand
.
isIntegrationTest
,
true
);
},
overrides:
<
Type
,
Generator
>{
FileSystem:
()
=>
fs
,
ProcessManager:
()
=>
FakeProcessManager
.
any
(),
DeviceManager:
()
=>
_FakeDeviceManager
(<
Device
>[
FakeDevice
(
'ephemeral'
,
'ephemeral'
,
type:
PlatformType
.
android
),
]),
});
testUsingContext
(
'when both test and integration test are passed'
,
()
async
{
final
FakeFlutterTestRunner
testRunner
=
FakeFlutterTestRunner
(
0
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment