Skip to content
Projects
Groups
Snippets
Help
Loading...
Help
Submit feedback
Sign in
Toggle navigation
F
Front-End
Project
Project
Details
Activity
Releases
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
abdullh.alsoleman
Front-End
Commits
3ee1d46d
Unverified
Commit
3ee1d46d
authored
Jun 22, 2021
by
Jenn Magder
Committed by
GitHub
Jun 22, 2021
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Check for either ios-x86_64-simulator or ios-arm64_x86_64-simulator in module test (#85051)
parent
eafadd8b
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
20 additions
and
8 deletions
+20
-8
build_ios_framework_module_test.dart
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
+20
-8
No files found.
dev/devicelab/bin/tasks/build_ios_framework_module_test.dart
View file @
3ee1d46d
...
...
@@ -270,24 +270,36 @@ Future<void> _testBuildIosFramework(Directory projectDir, { bool isModule = fals
await
_checkBitcode
(
engineFrameworkPath
,
mode
);
checkFileExists
(
path
.
join
(
// TODO(jmagman): Remove ios-x86_64-simulator checks when the ARM simulator engine artifacts rolls.
final
String
x86SimulatorFramework
=
path
.
join
(
outputPath
,
mode
,
'Flutter.xcframework'
,
'ios-x86_64-simulator'
,
'Flutter.framework'
,
'Flutter'
,
));
);
checkFileExists
(
path
.
join
(
final
String
x86ArmSimulatorFramework
=
path
.
join
(
outputPath
,
mode
,
'Flutter.xcframework'
,
'ios-x86_64-simulator'
,
'ios-
arm64_
x86_64-simulator'
,
'Flutter.framework'
,
'Headers'
,
'Flutter.h'
,
));
);
final
bool
x86SimulatorBinaryExists
=
exists
(
File
(
path
.
join
(
x86SimulatorFramework
,
'Flutter'
)));
final
bool
x86ArmSimulatorBinaryExists
=
exists
(
File
(
path
.
join
(
x86ArmSimulatorFramework
,
'Flutter'
)));
if
(!
x86SimulatorBinaryExists
&&
!
x86ArmSimulatorBinaryExists
)
{
throw
TaskResult
.
failure
(
'Expected Flutter engine artifact binary to exist'
);
}
final
bool
x86SimulatorHeaderExists
=
exists
(
File
(
path
.
join
(
x86SimulatorFramework
,
'Headers'
,
'Flutter.h'
)));
final
bool
x86ArmSimulatorHeaderExists
=
exists
(
File
(
path
.
join
(
x86ArmSimulatorFramework
,
'Headers'
,
'Flutter.h'
)));
if
(!
x86SimulatorHeaderExists
&&
!
x86ArmSimulatorHeaderExists
)
{
throw
TaskResult
.
failure
(
'Expected Flutter.h engine artifact to exist'
);
}
}
section
(
'Check all modes have plugins'
);
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment